Ruby.Metaprogramming.class_eval

Question

我的代码中似乎有一个错误.但是我无法找到它.

class Class
def attr_accessor_with_history(attr_name)
  attr_name = attr_name.to_s

  attr_reader attr_name
  attr_writer attr_name

  attr_reader attr_name + "_history"
  class_eval %Q{
   @#{attr_name}_history=[1,2,3]
  }

end
end

class Foo
 attr_accessor_with_history :bar
end

f = Foo.new
f.bar = 1
f.bar = 2
puts f.bar_history.to_s

我希望它能返回一个数组[1,2,3].但是,它不返回任何东西.

Answer 1

您不应该打开Class添加新方法.这就是模块的用途.

module History
  def attr_accessor_with_history(attr_name)
    attr_name = attr_name.to_s

    attr_accessor attr_name

    class_eval %Q{
      def #{attr_name}_history
        [1, 2, 3]
      end
    }

  end
end

class Foo
  extend History
  attr_accessor_with_history :bar
end

f = Foo.new
f.bar = 1
f.bar = 2
puts f.bar_history.inspect
# [1, 2, 3]

这里是您可能要写的代码(从名称来看).

module History
  def attr_accessor_with_history(attr_name)
    attr_name = attr_name.to_s

    class_eval %Q{
      def #{attr_name}
        @#{attr_name}
      end

      def #{attr_name}= val
        @#{attr_name}_history ||= []
        @#{attr_name}_history << #{attr_name}

        @#{attr_name} = val
      end

      def #{attr_name}_history
        @#{attr_name}_history
      end
    }

  end
end

class Foo
  extend History
  attr_accessor_with_history :bar
end

f = Foo.new
f.bar = 1
f.bar = 2
puts f.bar_history.inspect
# [nil, 1]

Answer 2

解:

class Class
  def attr_accessor_with_history(attr_name)
    ivar         = "@#{attr_name}"
    history_meth = "#{attr_name}_history"
    history_ivar = "@#{history_meth}"

    define_method(attr_name) { instance_variable_get ivar }

    define_method "#{attr_name}=" do |value|
      instance_variable_set ivar, value
      instance_variable_set history_ivar, send(history_meth) << value
    end

    define_method history_meth do
      value = instance_variable_get(history_ivar) || []
      value.dup
    end
  end
end

测试:

describe 'Class#attr_accessor_with_history' do
  let(:klass)     { Class.new { attr_accessor_with_history :bar } }
  let(:instance)  { instance = klass.new }

  it 'acs as attr_accessor' do
    instance.bar.should be_nil
    instance.bar = 1
    instance.bar.should == 1
    instance.bar = 2
    instance.bar.should == 2
  end

  it 'remembers history of setting' do
    instance.bar_history.should == []
    instance.bar = 1
    instance.bar_history.should == [1]
    instance.bar = 2
    instance.bar_history.should == [1, 2]
  end

  it 'is not affected by mutating the history array' do
    instance.bar_history << 1
    instance.bar_history.should == []
    instance.bar = 1
    instance.bar_history << 2
    instance.bar_history.should == [1]
  end
end