Data.ByteString中的findSubstrings和breakSubstring

sob*_*b7y 6 performance haskell string-matching bytestring

Data/ByteString.hs它的来源中说该函数findSubstrings已被弃用而有利于breakSubstring.但是我认为findSubstrings使用KMP算法实现的算法比使用的算法更有效率breakSubstring.任何人都知道为什么要这样做?

这是旧的实现:

{-# DEPRECATED findSubstrings "findSubstrings is deprecated in favour of breakSubstring." #-}

{-
{- This function uses the Knuth-Morris-Pratt string matching algorithm.  -}

findSubstrings pat@(PS _ _ m) str@(PS _ _ n) = search 0 0
where
  patc x = pat `unsafeIndex` x
  strc x = str `unsafeIndex` x

  -- maybe we should make kmpNext a UArray before using it in search?
  kmpNext = listArray (0,m) (-1:kmpNextL pat (-1))
  kmpNextL p _ | null p = []
  kmpNextL p j = let j' = next (unsafeHead p) j + 1
                     ps = unsafeTail p
                     x = if not (null ps) && unsafeHead ps == patc j'
                            then kmpNext Array.! j' else j'
                    in x:kmpNextL ps j'
  search i j = match ++ rest -- i: position in string, j: position in pattern
    where match = if j == m then [(i - j)] else []
          rest = if i == n then [] else search (i+1) (next (strc i) j + 1)
  next c j | j >= 0 && (j == m || c /= patc j) = next c (kmpNext Array.! j)
           | otherwise = j
-}
Run Code Online (Sandbox Code Playgroud)

这是新的天真的:

findSubstrings :: ByteString -- ^ String to search for.
           -> ByteString -- ^ String to seach in.
           -> [Int]
findSubstrings pat str
    | null pat         = [0 .. length str]
    | otherwise        = search 0 str
where
    STRICT2(search)
    search n s
        | null s             = []
        | pat `isPrefixOf` s = n : search (n+1) (unsafeTail s)
        | otherwise          =     search (n+1) (unsafeTail s)
Run Code Online (Sandbox Code Playgroud)

Don*_*art 4

更改的原因是 KMP 的实现实际上比 naive 版本效率更低,naive 版本是着眼于性能实现的。

  • 理论上是这样。我的意思是,在实践中,这种实现效率非常低,以至于在我运行的所有测试中都达到了幼稚的版本。 (2认同)