django ValidationError 未在测试中引发，但在 shell 中引发

Question

我在下面定义了一个模型，它在 clean() 方法中调用管理器。

from django.core.exceptions import ValidationError
from django.db import models
from re import sub

class Vessel(models.Model):
    name = models.CharField(max_length=50)
    stripped_name = models.CharField(
        max_length=50, unique=True, null=True, blank=True
    )

    def save(self, *args, **kwargs):
        stripped_name = sub(r'\s+', ' ', str(self.name).upper().strip())
        stripped_name = sub(r'^M[^a-zA-Z]*V\s*', '', stripped_name)
        stripped_name = sub(r'[^\w]', '', str(stripped_name).upper())
        self.stripped_name = stripped_name
        super().save(*args, **kwargs)

    def clean(self):
        stripped_name = sub(r'\s+', ' ', str(self.name).upper().strip())
        stripped_name = sub(r'^M[^a-zA-Z]*V\s*', '', stripped_name)
        stripped_name = sub(r'[^\w]', '', str(stripped_name).upper())
        if Vessel.objects.all().filter(stripped_name = stripped_name).exists():
            return ValidationError("Vessel name exists.")

在新刷新的 shell 中，IntegrityError 会正常引发。

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.save() # Raises IntegrityError

即使 ValidationError 也能很好地引发。

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.clean() # Raises ValidationError

但在自动化测试中，不会引发 ValidationError 。

from django.core.exceptions import ValidationError
from django.db.utils import IntegrityError
from django.test import TestCase

from my_random_app.models import Vessel

class  VesselTest(TestCase):

    def setUp(self):
        pass

    def test_a(self):
        vessel = Vessel(name='PM Hayabusa')
        vessel.save()
        vessel = Vessel(name=' M/V PM-HAYABUSA')
        self.assertRaises(IntegrityError, vessel.save)

    def test_b(self):
        vessel = Vessel(name='PM Hayabusa')
        vessel.save()
        vessel = Vessel(name=' M/V PM-HAYABUSA')

        # This line FAILS!
        self.assertRaises(ValidationError, vessel.clean)

这与我在 clean() 方法中调用管理器的方式有关吗？为什么在 shell 中会出现验证错误，但在测试中不会出现验证错误？

Answer 1

你所做的几乎是完美的:)

ValidationError 是一个异常，需要引发一些异常，而不是返回。

如果你更换return->raise你的问题就会解决。

        if Vessel.objects.all().filter(stripped_name = stripped_name).exists():
            raise ValidationError("Vessel name exists.")

当您在 shell 中执行此操作时，clean 方法会返回错误，因此您认为它工作正常，但实际上并非如此。

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.clean() # Returns ValidationError
ValidationError(['Vessel name exists.'])

当它升高时，它变成如下所示：

>>> from my_random_app.models import Vessel
>>> vessel = Vessel(name='PM Hayabusa')
>>> vessel.save()
>>> vessel = Vessel(name=' M/V PM-HAYABUSA')
>>> vessel.clean()
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/***/**/myapp/models.py", line 25, in clean
    raise ValidationError("Vessel name exists.")
django.core.exceptions.ValidationError: ['Vessel name exists.']