一种遍历列表以比较两个相邻元素的更优雅的方法

Question

我有一种方法可以这样工作：

1. 以3个参数作为参数-带有日期（按升序排列），间隔单位和间隔值的列表
2. 检查下一个元素是否不超过上一个日期（间隔）。换句话说，给定间隔30分钟，上一个-10:00，下一个10:29-进一步迭代。如果下一个是10:31-打破它，然后连续返回日期计数器。

它的代码如下：

public static void main(String[] args)
{
    Date d1 = new Date();
    Date d2 = addOrSubtractTimeUnitFromDate(d1, Calendar.MINUTE, 10, true);
    Date d3 = addOrSubtractTimeUnitFromDate(d2, Calendar.MINUTE, 10, true);
    Date d4 = addOrSubtractTimeUnitFromDate(d3, Calendar.MINUTE, 10, true);
    Date d5 = addOrSubtractTimeUnitFromDate(d4, Calendar.MINUTE, 10, true);
    Date d6 = addOrSubtractTimeUnitFromDate(d5, Calendar.MINUTE, 10, true);

    List<Date> threeDates = new ArrayList<>();
    threeDates.add(d1);
    threeDates.add(d2);
    threeDates.add(d3);
    threeDates.add(d4);
    threeDates.add(d5);
    threeDates.add(d6);

    System.out.println(returnDatesInARowCounter(threeDates, Calendar.MINUTE, 30));
}

private static int returnDatesInARowCounter(List<Date> allDates, int intervalBetween2DatesTimeUnit, int intervalValue)
{
    int datesInARowCounter = allDates.size() > 0 ? 1 : 0; // esp. this line (in case allDates is empty)
    Date lastDate = null;
    Date nextDate;

    Iterator<Date> iter = allDates.iterator();

    while (iter.hasNext())
    {
        nextDate = iter.next();

        if (lastDate != null) // both lastDate ? nextDate are initialized now
        {
            if(isNextIncidentInIntervalWithLastOneOrNot(lastDate, nextDate, intervalBetween2DatesTimeUnit, intervalValue, true))
            {
                datesInARowCounter += 1;
            }
            else break;
        }

        lastDate = nextDate;
    }

    return datesInARowCounter;
}

public static Date addOrSubtractTimeUnitFromDate(Date dateToAddToOrSubtractFrom, int calendarTimeUnit, int value, boolean isAdd)
{
    if(!isAdd)
    {
        value = -value;
    }
    Calendar cal = Calendar.getInstance();
    cal.setTime(dateToAddToOrSubtractFrom);
    cal.add(calendarTimeUnit, value);
    return cal.getTime();
}

private static boolean isNextIncidentInIntervalWithLastOneOrNot(Date lastIncidentRegDate, Date nextIncidentRegDate, int intervalTimeUnit, int intervalValue, boolean isBetween)
{
    Date currentIncidentPlusInterval = addOrSubtractTimeUnitFromDate(lastIncidentRegDate, intervalTimeUnit, intervalValue, true);
    boolean betweenBool = isDateBetween(nextIncidentRegDate, lastIncidentRegDate, currentIncidentPlusInterval);

    return isBetween == betweenBool;
}

private static boolean isDateBetween(Date targetDate, Date startDate, Date endDate)
{
    return targetDate.compareTo(startDate) >= 0 && targetDate.compareTo(endDate) <= 0;
}

但是，代码对我来说似乎是特有的。有什么办法使它看起来更具可读性？

Answer 1

如果您使用的是Java 8或更高版本，则可以改用java.time-API。它对“时间段”的内置支持使实际实现变得更加简单。

static int daysInARow(List<Instant> allInstants, Duration maxDifference) {
        int counter = allInstants.size() > 0 ? 1 : 0;
        Instant previous = allInstants.get(0);

        for (int i = 1; i < allInstants.size(); i++) {
            Instant current = allInstants.get(i);
            if (Duration.between(previous, current).compareTo(maxDifference) > 0)
                break;
            counter++;
            previous = current;
        }

        return counter;
    }

如果java.util.Date在项目的其他部分使用，则可以Instant通过使用轻松在s 之间进行转换

Date#from(Instant)

和

Date#toInstant()