调用不同函数时,通过堆分配创建未初始化的值

Question

代码如下:

Board* constructBoard(int dimension)
{
    //Allocate memory for board
    Board *board = malloc(sizeof(Board));
    if(!board)
    {
        return NULL;
    }
    //Allocate memory for matrix
    board->matrix = malloc(dimension * sizeof(int*));
    if(!board->matrix)
    {
        freeBoard(board);
        return NULL;
    }
    //Allocate memory for each row of matrix
    for(int row = 0; row < dimension; row++)
    {
        // Following line is line 29 from error below  <---------------------------
        board->matrix[row] = malloc(dimension * sizeof(int));  
        if(!board->matrix[row])
        {
            freeBoard(board);
            return NULL;
        }
        board->dimension = row +1;
    }
    board->value = 0;
    return board;
}

void printBoard(Board *board, char* delimiter)
{
    assert(board && "printBoard must get an initialized board");
    for(int i = 0; i < board->dimension; i++)
    {
        for (int j = 0; j < board->dimension; j++)
        {
            printf("%d%s", board->matrix[i][j], delimiter);
        }
        printf("\n");
    }
}

当从main调用这样的时候:

Board *final = constructBoard(4);
printBoard(final, SEPARATOR);
freeBoard(final);

导致以下valgrind错误(请参阅上面代码中的注释错误行):

==8450==  Uninitialised value was created by a heap allocation
==8450==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==8450==    by 0x401560: constructBoard (Board.c:29)
==8450==    by 0x400FAB: main (SudokuSolver.c:181)

定义Board:

typedef struct Board
{
    int** matrix;
    int dimension;
    unsigned int value;
} Board;

当我不添加呼叫printBoard一切都很好.

1. 为什么我只在使用时才收到错误printBoard？
2. 为什么当我得到错误它说它在constructBoard？

我已经读过这些先前的问题,但我仍然无法解决它,因为我正确分配了内存并确保循环仅迭代有效索引:

1. 未初始化的值由堆栈分配创建
2. 未初始化的值是由堆栈分配创建的 - valgrind
3. 未初始化的值由堆栈分配创建

我用以下标志编译:

gcc -g -c -Wextra -Wall -Wvla -DNDEBUG -std=c99

Answer 1

该malloc函数只分配内存,它不以任何方式初始化该内存.内存的内容是不确定的.

您在printBoard函数中打印此未初始化内存的内容,从而导致出现警告.

如果你想初始化内存,那么要么显式地做,要么calloc用来分配和"清除"(零)内存(它相当于malloc后面跟着memset).