领域数据插入大型json需要7分钟

Question

我使用Alamofire下载大约7MB的大json数据,并使用RealmSwift将数据存储在realmobject和SwiftyJSON来解析.我完成下载之后的域对象插入json在插入时似乎很慢.我的错误代码有问题吗？请指导我.

首先,我将展示最简单的Json:

{
    {
        "Start" : "40000",
        "End" : "1000000",
        "Name" : "Smith",
        "Address" : "New York"
    },{...},more than 7000 records...
}

这是我的AlamofireAPI协议

import Foundation
import Alamofire
import SwiftyJSON

protocol RequestDataAPIProtocol{
    func didSuccessDownloadingData(results:JSON,statusCode : Int)
    func didFailDownloadingData(err : NSError)
}

class RequestDataAPI{

var delegate : RequestDataAPIProtocol
init(delegate: RequestDataAPIProtocol){
    self.delegate=delegate
}

func post(requestURL:String,param:[String:String]){
    Alamofire.request(.GET, requestURL, parameters: param)
        .validate(statusCode: [200,500])
        .responseJSON(completionHandler: { (response: Response<AnyObject, NSError>) -> Void in
            if let error = response.result.error {
                self.delegate.didFailDownloadingData(error)
            } else if let jsonObject: AnyObject = response.result.value {
                let json = JSON(jsonObject)
                self.delegate.didSuccessDownloadingData(json,statusCode: (response.response?.statusCode)!)
            }
        })
}

func doRequestSiteData(token : String){
    post(REQUEST_DATA,param:["data":"All","token":token])
}

}

这是我的Realm DB Helper

import Foundation
import RealmSwift

class DBHelper{

func insertUserData(list: UserList){
    do {
        let realm = try! Realm()
        try realm.write({ () -> Void in
            realm.add(list,update: true)
        })
    } catch let error as NSError {
        print("Insert Error : \(error)")
    }
}
}

这是我的领域modelObject

import Foundation
import RealmSwift

class UserList: Object {

     dynamic var start : String = ""
     dynamic var end : String = ""
     dynamic var name : String = ""
     dynamic var address : String = ""

}

最终代码,视图控制器,

class ViewController : UIViewController , RequestDataAPIProtocol{
       var dbHelper = DBHelper()
       var requestDataAPI : RequestDataAPI!

       override func viewDidLoad() {
           super.viewDidLoad()
           requestDataAPI = RequestDataAPI(delegate : self)
       }

       override func viewDidAppear(animated : Bool){
            //assume there is one token to request data
            requestDataAPI.doRequestSiteData(token)
       }

       func didSuccessDownloadingData(results: JSON, statusCode: Int){
        dispatch_async(dispatch_get_main_queue(), {
            print("Downloaded JSON")
            switch statusCode{
            case 200 :
               if results.count > 0{
                   if let users = results.array {
                      for user in users{
                         let userList=UserList()
                         userList.start=user["Start”].stringValue
                         userList.end=user[“End”].stringValue
                         userList.name=user[“Name”].stringValue
                         userList.address =user[“Address”].stringValue
                         self.dbHelper.insertUserData(userList)
                      }
                   }
               }
               // took about more than 7 mins
               print(“Insertion Done”)
               break

           case 500,401,400 :
               //TODO: 
           default : break
           }
        })
    }
}

我知道它对于描述所有代码步骤非常愚蠢,我尽可能简单地编写我的工作流程,以便将json数据插入到realm swift中.

我只想让所有人知道我的工作流程在处理如此多的json数据时的好坏,以及插入.

我之所以这么说是因为数据插入花了大约7分钟才完成.

所以,我真的需要帮助,对我的代码进行优化.

任何指南？

更新:我使用来自RequestDataAPI的Delegate和Protocol,我从JamesQueue Tutorial中学习了这个样式,因为我是初学者,他还在学习Swift.ViewController更新.这是我的整个过程细节,没有更多的代码了.编辑我的问题或回答一个问题对于代码优化,我们非常感谢.

Answer 1

insertUserData方法方法在循环中多次打开事务.提交事务是一个有点贵的操作.

你能尝试在循环之外打开/提交一个事务吗？换句话说,在进入循环之前打开事务,并在循环结束后提交事务一次.如下:

if results.count > 0 {
    if let users = results.array {
        let realm = try! Realm()
        try realm.write {
            for user in users{
                let userList=UserList()
                userList.start=user["Start”].stringValue
                userList.end=user[“End”].stringValue
                userList.name=user[“Name”].stringValue
                userList.address =user[“Address”].stringValue
                realm.add(userList,update: true)
            }
        }
    }
}