我违反DRY请帮帮我吗?

y2k*_*y2k 2 c++ refactoring dry blackjack

我正在制作一个二十一点的卡片,我想要在卡片中处理它如何在赌场,

即所有玩家获得一张牌,经销商一张面朝下,玩家获得另一张牌,经销商一张面朝上

但是我看起来是暴力干的:(如何重做?

void BlackJack::newHand()
{
    resetHands();

    for (unsigned int i = 0; i < players.size(); i++)
        players[i]->addCard(deck->nextCard());

    Card* c = deck->nextCard();
    c->setVisible(false); // dealer gets a face down card
    dealer->addCard(c);

    for (unsigned int i = 0; i < players.size(); i++)
        players[i]->addCard(deck->nextCard());

    dealer->addCard(deck->nextCard());
}
Run Code Online (Sandbox Code Playgroud)

Geo*_*che 13

将重复的代码移动到另一个函数中:

void BlackJack::addDealerCard(bool visible) {
    Card* c = deck->nextCard();
    c->setVisible(visible); 
    dealer->addCard(c);
}

void BlackJack::addCards() {
     for (unsigned int i = 0; i < players.size(); i++)
        players[i]->addCard(deck->nextCard());
}

void BlackJack::newHand() {
    resetHands();

    addCards();    
    addDealerCard(false);

    addCards();    
    addDealerCard(true);
}
Run Code Online (Sandbox Code Playgroud)