查找与给定条件匹配的元素索引

Mis*_*hko 61 ruby arrays

给定一个数组,如何找到符合给定条件的所有元素索引?

例如,如果我有:

arr = ['x', 'o', 'x', '.', '.', 'o', 'x']
Run Code Online (Sandbox Code Playgroud)

要查找项目所在的所有索引x,我可以这样做:

arr.each_with_index.map { |a, i| a == 'x' ? i : nil }.compact   # => [0, 2, 6]
Run Code Online (Sandbox Code Playgroud)

要么

(0..arr.size-1).select { |i| arr[i] == 'x' }   # => [0, 2, 6]
Run Code Online (Sandbox Code Playgroud)

有没有更好的方法来实现这一目标?

ste*_*lag 89

Ruby 1.9:

arr = ['x', 'o', 'x', '.', '.', 'o', 'x']
p arr.each_index.select{|i| arr[i] == 'x'} # =>[0, 2, 6]
Run Code Online (Sandbox Code Playgroud)

  • @ 6ftDan`deleval_if {| i | i.nil?}`==`compact`. (3认同)

AGS*_*AGS 24

其他方式:

arr.size.times.select {|i| arr[i] == 'x'} # => [0, 2, 6]
Run Code Online (Sandbox Code Playgroud)

编辑:

不确定这是否是必要的,但在这里它们是.

基准:

arr = 10000000.times.map{rand(1000)};

Benchmark.measure{arr.each_with_index.map { |a, i| a == 50 ? i : nil }.compact}
2.090000   0.120000   2.210000 (  2.205431)

Benchmark.measure{(0..arr.size-1).select { |i| arr[i] == 50 }}
1.600000   0.000000   1.600000 (  1.604543)

Benchmark.measure{arr.map.with_index {|a, i| a == 50 ? i : nil}.compact}
1.810000   0.020000   1.830000 (  1.829151)

Benchmark.measure{arr.each_index.select{|i| arr[i] == 50}}
1.590000   0.000000   1.590000 (  1.584074)

Benchmark.measure{arr.size.times.select {|i| arr[i] == 50}}
1.570000   0.000000   1.570000 (  1.574474)
Run Code Online (Sandbox Code Playgroud)

  • 我想说公认的答案更直接;`arr.size.times == arr.each_index`。只需调用一个方法而不是两个。但根据此处添加的基准显然有点慢? (2认同)

Ser*_*sev 12

你的each_with_index.map生产线略有改进

arr.map.with_index {|a, i| a == 'x' ? i : nil}.compact # => [0, 2, 6]
Run Code Online (Sandbox Code Playgroud)


pet*_*ter 7

这种方法有点长,但速度快一倍

class Array
  def find_each_index find
    found, index, q = -1, -1, []
    while found
      found = self[index+1..-1].index(find)
      if found
        index = index + found + 1
        q << index
      end
    end
    q
  end
end

arr = ['x', 'o', 'x', '.', '.', 'o', 'x']
p arr.find_each_index 'x'
# [0, 2, 6]
Run Code Online (Sandbox Code Playgroud)

这里AGS的基准就是这个解决方案

arr = 10000000.times.map{rand(1000)};

puts Benchmark.measure{arr.each_with_index.map { |a, i| a == 50 ? i : nil }.compact}
puts Benchmark.measure{(0..arr.size-1).select { |i| arr[i] == 50 }}
puts Benchmark.measure{arr.map.with_index {|a, i| a == 50 ? i : nil}.compact}
puts Benchmark.measure{arr.each_index.select{|i| arr[i] == 50}}
puts Benchmark.measure{arr.size.times.select {|i| arr[i] == 50}}
puts Benchmark.measure{arr.find_each_index 50}

  # 1.263000   0.031000   1.294000 (  1.267073)
  # 0.843000   0.000000   0.843000 (  0.846048)
  # 0.936000   0.015000   0.951000 (  0.962055)
  # 0.842000   0.000000   0.842000 (  0.839048)
  # 0.843000   0.000000   0.843000 (  0.843048)
  # 0.405000   0.000000   0.405000 (  0.410024)
Run Code Online (Sandbox Code Playgroud)


Mar*_*eed 5

不确定您是否认为这是一种改进,但是使用 ( map+ compact) 作为过滤器对我来说感觉很笨拙。我会使用select,因为这就是它的用途,然后只获取我关心的结果部分:

arr.each_with_index.select { |a,i| a == 'x' }.map &:last
Run Code Online (Sandbox Code Playgroud)


Jun*_*Ito 5

我定义了Array#index_all它的行为Array#index,但返回所有匹配的索引。此方法可以接受参数并阻止。

class Array
  def index_all(obj = nil)
    if obj || block_given?
      proc = obj ? ->(i) { self[i] == obj } : ->(i) { yield self[i] }
      self.each_index.select(&proc)
    else
      self.each
    end
  end
end

require 'test/unit'

class TestArray < Test::Unit::TestCase
  def test_index_all
    arr = ['x', 'o', 'x', '.', '.', 'o', 'x']
    result = arr.index_all('x')
    assert_equal [0, 2, 6], result

    arr = [100, 200, 100, 300, 100, 400]
    result = arr.index_all {|n| n <= 200 }
    assert_equal [0, 1, 2, 4], result
  end
end
Run Code Online (Sandbox Code Playgroud)