VBA快速将许多记录插入Access DB

Question

好，所以我有一个电子表格可以产生大量记录（〜3500）

我有以下脚本将它们插入到我的Access数据库中：

Sub putinDB()
Dim Cn As ADODB.Connection, Rs As ADODB.Recordset
Dim MyConn, sSQL As String

Dim Rw As Long, c As Long
Dim MyField, Result
Dim x As Integer
Dim accName As String, AccNum As String, sector As String, holding As String,  holdingvalue As Double, holdingdate As Date
theend = lastRow("Holdings", 1) - 1
'Set source
MyConn = "S:\Docs\Harry\Engine Client\Engine3.accdb"
'Create query
Set r = Sheets("Holdings").Range("a2")
x = 0
Do
Application.StatusBar = "Inserting record " & x + 1 & " of " & theend
accName = r.Offset(x, 0)
AccNum = r.Offset(x, 4)
sector = r.Offset(x, 2)
holding = r.Offset(x, 1)
holdingvalue = r.Offset(x, 3)
holdingdate = r.Offset(x, 5)

sSQL = "INSERT INTO Holdings (AccName, AccNum, Sector, Holding, HoldingValue, HoldingDate)"
sSQL = sSQL & " VALUES ('" & Replace(accName, "'", "''") & "', '" & AccNum & "', '" & sector & "', '" & Replace(holding, "'", "''") & "', '" & holdingvalue & "', #" & holdingdate & "#)"
Debug.Print (sSQL)
 'Create RecordSet
Set Cn = New ADODB.Connection
With Cn
    .Provider = "Microsoft.ACE.OLEDB.12.0"
    .CursorLocation = adUseClient
    .Open MyConn
    Set Rs = .Execute(sSQL)
End With
x = x + 1
Loop While r.Offset(x, 0) <> "" Or x < 15
Application.StatusBar = False
End Sub

问题在于，它会一条一条地遍历每个记录，每次都重建并执行查询，这导致执行速度非常慢（在我的PC上每秒大约有2-3条记录）

有没有一种方法可以让vba一次性将整个范围插入数据库，而无需循环通过？谢谢

Answer 1

您提供的答案应该可以稍微改善一下情况，因为您只需要打开一次连接，但是代码仍然效率不高。您真的只想将所有数据写入记录集一次，而不是这样。我总是更喜欢在Access方面进行工作，以从Excel中提取信息，而不是从Excel中引入Access，但是我相信我们可以在这种情况下使用其中一种方法。

在这种情况下，最好在ADO上使用DAO并使用Transacation，从本质上讲，您仍会遍历记录集，但是直到最后提交时才发生写入数据的实际操作，因此速度要快得多。

这是Access端一个非常基本的示例，供您尝试：

Private Sub TestTrans()

Dim wksp    As DAO.Workspace
Dim rs      As DAO.Recordset

    Set wksp = DBEngine.Workspaces(0) 'The current database

    wksp.BeginTrans 'Start the transaction buffer

    Set rs = CurrentDb.OpenRecordset("Table1", dbOpenDynaset)

    Do 'Begin your loop here

    With rs
        .AddNew
            !Field = "Sample Data"
        .Update
    End With

    Loop 'End it here

    wksp.CommitTrans 'Commit the transaction to dataset

End Sub