C++禁止可变大小的数组

Question

我正在使用其他人编写的一些现有代码,我无法编译(这里有限的C经验,但我正在努力学习!).

utilities.cc

#include "utilities.h"
FILE *open_file(char *filename, const char*extension, const char *access)
{
  char string[MAX_STR_LEN];
  FILE *strm = NULL;

  if(filename[0]=='\0')
   {
      printf("\n INPUT FILENAME (%s) > ",access);
      fgets(string,MAX_STR_LEN,stdin);
      sscanf(string,"%s",filename);
      printf(" FILE %s opened \n", filename);
   }
   int len=strlen(filename);

   if( len + strlen(extension) >= MAX_STR_LEN)
   {
      printf("\n ERROR: String Length  of %s.%s Exceeds Maximum",
              filename, extension);
      return(NULL);
   } 

   // char *filename1 = new(char[len+strlen(extension)+1]);

   const int filenameLength = len+strlen(extension)+1;
   char *filename1 = new(char[filenameLength]);

   strcpy(filename1,filename); // temp filename for appending extension

   /* check if file name has .extension    */
   /* if it does not, add .extension to it */
   int i=len-1;
   while(i > 0 && filename[i--] != '.');
   //   printf("\n Comparing %s to %s", extension, filename+i+1);
   if(strcmp(extension, filename+i+1)  )
      strcat(filename1,extension);
   if( (strm = fopen(filename1, access) ) == NULL )
   {
      printf("\n ERROR OPENING FILE %s (mode %s)", filename1,access);
   }
   delete(filename1);
   return(strm);
}

这是错误.

Compiling utilities.cc ...
src/utilities.cc: In function ‘FILE* open_file(char*, const char*, const char*)’:
src/utilities.cc:251: error: ISO C++ forbids variable-size array
gmake: *** [/home/landon/geant4/work/tmp/Linux-g++/exampleN01/utilities.o] Error 1

第251行的错误是指

char *filename1 = new(char[filenameLength]);

如果您需要任何其他信息,请告诉我们.

Answer 1

错误是正确的.在C++中禁止使用VLA(可变大小的数组).这是一个VLA:

char filename1char[filenameLength];

你可能的意思是:

char *filename1 = new char[filenameLength];

哪个不是VLA,而是char在堆上分配的s 数组.请注意,您应该使用运算符删除此指针delete[]:

delete[] filename1;

Answer 2

试试这个

    char *filename1 = new char[filenameLength];

你不能像这样在堆栈上创建一个数组作为局部变量长度数组

    char filename1[filenamelength];

除非filenamelength被宣布为const.

此外,由于您已为阵列分配内存,因此应使用释放内存

   delete [] filename1;

否则你会有内存泄漏.此外,围绕您的return价值观括号也不是必需的;