我们如何改进以下代码？

Question

我们可以改进这行代码吗？

if ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType != DeviceType.UnKnown)).Count() > 0)
        {
            //l_Subscription.DeviceTypeID = ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType == DeviceType.Tablet)).Count() > 0)?()
            if ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType == DeviceType.Tablet)).Count() > 0)
                l_Subscription.DeviceTypeID = (int)DeviceType.Tablet;
            else if ((l_Subscription.PackageInfo.Applications.Where(x => x.DeviceType == DeviceType.Phone)).Count() > 0)
                l_Subscription.DeviceTypeID = (int)DeviceType.Phone;
        }

我只是尝试了以下但没有工作......需要帮助

int cnt =  DoOperation(l_Subscription.PackageInfo.Applications, x => x.DeviceType != DeviceType.UnKnown);
       if(cnt > 0)
       {
           int cnt1 =  DoOperation(l_Subscription.PackageInfo.Applications, x => x.DeviceType == DeviceType.Tablet);
           int cnt2 =  DoOperation(l_Subscription.PackageInfo.Applications, x => x.DeviceType == DeviceType.Phone);

           if(cnt1 > 0) l_Subscription.DeviceTypeID = (int)DeviceType.Tablet;
           else if (cnt2 > 0) l_Subscription.DeviceTypeID = (int)DeviceType.Phone;           
       }

        private int DoOperation<TKey>(List<l_Subscription.PackageInfo.Applications> list, Func<l_Subscription.PackageInfo.Applications, TKey> predicate)
        {        
            int count = 0;
            count = list.Where(predicate).Count();
            return count;
        }

Answer 1

一个简单的改进就是替换

.Where( predicate ).Count() > 0

同

.Any( predicate )

哦,如果这是你的所有代码,你可以删除外部if,因为内部if条件和内部else条件暗示外部if条件,给你:

if ((l_Subscription.PackageInfo.Applications.Any(x => x.DeviceType == DeviceType.Tablet))
    l_Subscription.DeviceTypeID = (int)DeviceType.Tablet;
else if ((l_Subscription.PackageInfo.Applications.Any(x => x.DeviceType == DeviceType.Phone))
    l_Subscription.DeviceTypeID = (int)DeviceType.Phone;