登录验证始终返回true

Question

我的代码是查询服务器,如果用户和密码正确,则返回"+"字符.否则它没有.不好的做法,但我只是用这个想法来学习我是初学者的C#和ASP.NET(我之前在JSP中编写了程序).

我的问题 :

• 目前,我似乎有一些错误导致我的方法总是返回true.情况并非如此.只有在对usersname/pass进行身份验证时才应该这样.
• 我希望它仅在用户未登录且未启动会话时才显示登录表单 - 调整代码的最佳方法是什么？

我的代码到目前为止:

   @{
    // Initialize general page variables
    string username = "";
    string password = "";
    bool rememberMe = false;

    // Validation
    bool isValid = true;

    // If this is a POST request, validate and process data
        if (IsPost) {
            username = Request.Form["username"];
            password = Request.Form["password"];
            rememberMe = Request.Form["remember"].AsBool();

            // Attempt to login to the external authentication server
            if(isValid){
                using (TcpClient client = new TcpClient("hosty.host.com", 110)) {
                using (NetworkStream stream = client.GetStream()) {
                using (StreamReader reader = new StreamReader(stream)) {
                using (StreamWriter writer = new StreamWriter(stream)) {
                    writer.WriteLine("USER " + username );
                    writer.WriteLine("PASS " + password );
                    string response = reader.ReadLine();
                    isValid = response[ 0 ] == '+';
                    Response.Write(response);
                    writer.WriteLine("quit\n");
                }
                }
                }
                }
            }

            if (isValid) {
                <text>IT WORKED---></text>
            //USER LOGGED IN/ SESSION STARTED


            } else {
                <text>IT DIDNT WORK :( </text>
                //USER NOT LOGGED IN, SESSION NOT STARTED
            }
        }
    }   
        <h2>Login Here</h2>
        <form action="" method="post">
          <fieldset>
            <legend>Login Form</legend>
            <label for="username">Username:
              <input type="text" name="username" id="username" value="" />
            </label>
            <label for="password">Password:
              <input type="password" name="password" id="password" value="" />
            </label>
            <label for="remember">
              <input class="checkbox" type="checkbox" name="remember" id="remember" checked="checked" />
              Remember me</label>
            <p>
              <input type="submit" name="login" id="login" value="Login" />
              &nbsp;
              <input type="reset" name="reset" id="reset" value="Reset" />
            </p>
          </fieldset>
        </form>
      </div>
          </fieldset>
        </form>

Answer 1

你开始isValid=true但如果你的程序甚至无法连接到服务器,那么isValid它仍然是真的.

因此,即使验证没有完成,也许您的用户甚至根本不进行验证,您从isValid开始并以相同结束.

代码原样,我将以false开头,并删除一行.

// Validation
    bool isValid = false;

    // If this is a POST request, validate and process data
        if (IsPost) {
            username = Request.Form["username"];
            password = Request.Form["password"];
            rememberMe = Request.Form["remember"].AsBool();

            // Attempt to login to the external authentication server
            // if(isValid)
            {
                using (TcpClient client = new TcpClient("hosty.host.com", 110)) {
                using (NetworkStream stream = client.GetStream()) {
                using (StreamReader reader = new StreamReader(stream)) {
                using (StreamWriter writer = new StreamWriter(stream)) {
                    writer.WriteLine("USER " + username );
                    writer.WriteLine("PASS " + password );
                    string response = reader.ReadLine();
                    isValid = response[ 0 ] == '+';
                    Response.Write(response);
                    writer.WriteLine("quit\n");
                }
                }
                }
                }
            }

            if (isValid) {
                <text>IT WORKED---></text>
            //USER LOGGED IN/ SESSION STARTED


            } else {
                <text>IT DIDNT WORK :( </text>
                //USER NOT LOGGED IN, SESSION NOT STARTED
            }
        }

也是那个页面.IsValid是Web表单上的现有参数.