在C++中"向量擦除迭代器超出范围"

Question

在这个C++代码中,我尝试从向量的末尾擦除元素但程序停止并且我收到消息: Expression: vector erase iterator outside range.

问题是什么？毕竟通过这个代码向量一个指针的向量或我在push_back中传递它们的方式只插入一个指针的副本？

int _tmain(int argc, _TCHAR* argv[])
{
    vector<Player*> allPlayers;
    allPlayers = createPlayers();

    int numPlayers;

    cout<<"Vector size: "<<allPlayers.size();
    cout<<endl;
    cout<<"How many players are involved in the game(1-4)?\n";
    cin>>numPlayers;
    cout<<endl;
    allPlayers.erase(allPlayers.end());

    return 0;
}


vector<Player*> createPlayers(){

    Player *Player1 = new Player(1,1500);
    Player *Player2 = new Player(2,1500);
    Player *Player3 = new Player(3,1500);
    Player *Player4 = new Player(4,1500);


    vector<Player*> allPlayers;
    allPlayers.push_back(Player1);
    allPlayers.push_back(Player2);
    allPlayers.push_back(Player3);
    allPlayers.push_back(Player4);


    return allPlayers;
}

Answer 1

.end()将迭代器返回到最后一个元素之后.这就是你得到这个错误的原因.您希望迭代器指向最后一个元素.不是最后一个元素的一个.

所以尝试将线路更改为:

allPlayers.erase(allPlayers.end() - 1);

并确保您正确处理向量为空的情况.

或者你可以使用.pop_back(),但在任何一种情况下,你都会想要处理内存泄漏以及评论中提到的内容泄漏.