hou*_*se9 14 sql-injection ruby-on-rails-3 ruby-on-rails-3.1
让我们说我有一个用户列表页面,您可以按不同的列排序,点击"电子邮件"时它将通过sort_by = email sort_direction = asc或desc
sort_by = "email" # really params[:sort_by]
sort_direction = "asc" # really params[:sort_direction]
User.order("#{sort_by} #{sort_direction}")
# SELECT "users".* FROM "users" ORDER BY email asc
Run Code Online (Sandbox Code Playgroud)
所以如果我们更改sort_by,那么按预期工作
sort_by = "email; DELETE from users; --"
User.order("#{sort_by} #{sort_direction}")
# SELECT "users".* FROM "users" ORDER BY email; DELETE from users; -- asc
Run Code Online (Sandbox Code Playgroud)
现在我们没有更多用户:(
我可以手动构建一个有效sort_by的白名单,并将params [:sort_by]与之比较,但希望有一些内置的方法来处理这种事情
bri*_*ker 26
瑞安贝茨的方法:
在你的控制器中:
def index
@users = User.order(sort_by + " " + direction)
end
private
def sort_by
%w{email name}.include?(params[:sort_by]) ? params[:sort_by] : 'name'
end
def direction
%w{asc desc}.include?(params[:direction]) ? params[:direction] : 'asc'
end
Run Code Online (Sandbox Code Playgroud)
基本上你是在制作一个白名单,但这很容易做到并且不易注射.