Sig*_*i44 1 php autowired symfony doctrine-orm
我想重构我的代码,但现在我有错误并且不明白是什么。Objectif :调用TokenService时不需要传递参数,并使用自动装配来自动装配EntityManager和Request,并且控制器调用服务时不设置它。
无法解析 App\Controller\TokenController::showTokens() 的参数 $tokenService 无法自动装配服务 App\Service\TokenService 方法 __construct() 的参数 $request 引用类 Symfony\Component\HttpFoundation\Request 但不存在此类服务。
前 :
/src/Controller/TokenController.php
<?php
namespace App\Controller;
use App\Service\TokenService;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\Request;
/**
* @Route("/v1")
*/
class TokenController
{
/** @var EntityManagerInterface $em */
private $em;
/** @var Request $request */
private $request;
/**
* TokenService constructor.
*
* @param Request $request
* @param EntityManagerInterface $em
*/
public function __construct(Request $request, EntityManagerInterface $em)
{
$this->request = $request;
$this->em = $em;
}
public function showTokens(Request $request, EntityManagerInterface $em): JsonResponse
{
$tokenService = new TokenService($request, $em);
return $tokenService->getTokens();
}
}
Run Code Online (Sandbox Code Playgroud)
/src/Service/TokenService.php
<?php
namespace App\Service;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
/**
* Class TokenService
* @package App\Service
*/
class TokenService
{
/** @var EntityManagerInterface $em */
private $em;
/** @var Request $request */
private $request;
/**
* TokenService constructor.
*
* @param Request $request
* @param EntityManagerInterface $em
*/
public function __construct(Request $request, EntityManagerInterface $em)
{
$this->request = $request;
$this->em = $em;
}
public function getTokens()
{
return true;
}
}
Run Code Online (Sandbox Code Playgroud)
后 :
/config/services.yaml
parameters:
services:
_defaults:
autowire: true
autoconfigure: true
App\:
resource: '../src/'
exclude:
- '../src/DependencyInjection/'
- '../src/Entity/'
- '../src/Kernel.php'
- '../src/Tests/'
App\Controller\:
resource: '../src/Controller/'
tags: ['controller.service_arguments']
App\Service\TokenService: ~
Run Code Online (Sandbox Code Playgroud)
/src/Controller/TokenController.php
<?php
namespace App\Controller;
use App\Service\TokenService;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\Request;
/**
* @Route("/v1")
*/
class TokenController
{
public function showTokens(Request $request, EntityManagerInterface $em, TokenService $tokenService): JsonResponse
{
return $tokenService->getTokens();
}
Run Code Online (Sandbox Code Playgroud)
/src/Service/TokenService.php
<?php
namespace App\Service;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\HttpFoundation\Request;
/**
* Class TokenService
* @package App\Service
*/
class TokenService
{
/** @var EntityManagerInterface $em */
private $em;
/** @var Request $request */
private $request;
/**
* TokenService constructor.
*
* @param Request $request
* @param EntityManagerInterface $em
*/
public function __construct(Request $request, EntityManagerInterface $em)
{
$this->request = $request;
$this->em = $em;
}
public function getTokens()
{
return true;
}
}
Run Code Online (Sandbox Code Playgroud)
谢谢 !
我想我们已经有一段时间没有提出一个很好的请求堆栈问题了。我做了一些搜索,但没有找到任何直接适用的答案并提供了不错的解释。
基本问题是 Symfony 框架支持嵌套请求。例如,当使用嵌入式控制器时,您会得到这些。所以没有实际的请求服务。事实上,Symfony 2.0 首次发布时曾经有过这样的情况,但当时确实是一团糟。支持嵌套请求服务是在容器级别完成的,这并不有趣。
于是就引入了一个叫请求栈的大锤来一劳永逸地解决问题。您注入请求堆栈而不是请求,然后在实际需要时访问该请求。
class TokenService
{
private $em;
private $requestStack;
public function __construct(RequestStack $requestStack, EntityManagerInterface $em)
{
$this->requestStack = $requestStack;
$this->em = $em;
}
public function getTokens()
{
$request = $this->requestStack->getMainRequest(); // or possibly getCurrentRequest depending on where the tokens are
return true;
}
Run Code Online (Sandbox Code Playgroud)
话虽如此,我个人只会传递来自控制器的请求。这样做就摆脱了我的“视情况而定”的评论。我还认为它稍微减少了所涉及的“魔力”。两种方法都会起作用。
class TokenService
{
public function getTokens(Request $request)
{
return true;
}
...
class TokenController
{
public function showTokens(Request $request, TokenService $tokenService): JsonResponse
{
return $tokenService->getTokens($request);
}
Run Code Online (Sandbox Code Playgroud)