C++ 11多线程:Valgrind未初始化的值警告

Question

我使用gcc 8.2.1在Linux下编译了以下虚拟程序:

#include <iostream>
#include <mutex>
#include <thread>

struct Foo
{
  void start() {
    thread = std::thread(&Foo::run, this);
  }

  void stop() {
    mutex.lock();
    done = true;
    mutex.unlock();

    thread.join();
  }

  void run() {
    bool tmp;

    for (;;) {
      mutex.lock();
      tmp = done;
      mutex.unlock();

      if (tmp)
        break;
    }
  }

  std::thread thread;
  std::mutex mutex;
  bool done;
};

int main()
{
  Foo foo;

  std::cout << "starting...\n";
  foo.start();

  std::cout << "stopping...\n";
  foo.stop();

  std::cout << "done\n";
}

如果我随后在valgrind 3.14.0下运行它,我会收到以下警告:

==30060== Thread 2:
==30060== Conditional jump or move depends on uninitialised value(s)
==30060==    at 0x1095F3: Foo::run() (in /.../a.out)
==30060==    by 0x109AAE: void std::__invoke_impl<void, void (Foo::*)(), Foo*>(std::__invoke_memfun_deref, void (Foo::*&&)(), Foo*&&) (in /.../a.out)
==30060==    by 0x109771: std::__invoke_result<void (Foo::*)(), Foo*>::type std::__invoke<void (Foo::*)(), Foo*>(void (Foo::*&&)(), Foo*&&) (in /.../a.out)
==30060==    by 0x10A012: decltype (__invoke((_S_declval<0ul>)(), (_S_declval<1ul>)())) std::thread::_Invoker<std::tuple<void (Foo::*)(), Foo*> >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (in /.../a.out)
==30060==    by 0x109FB8: std::thread::_Invoker<std::tuple<void (Foo::*)(), Foo*> >::operator()() (in /.../a.out)
==30060==    by 0x109F8D: std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (Foo::*)(), Foo*> > >::_M_run() (in /.../a.out)
==30060==    by 0x496A062: execute_native_thread_routine (thread.cc:80)
==30060==    by 0x4894A9C: start_thread (in /usr/lib/libpthread-2.28.so)
==30060==    by 0x4CD7A42: clone (in /usr/lib/libc-2.28.so)

我不完全确定导致这种情况的原因,我已经编写了这段代码,希望能够诊断一个更复杂的类中的错误(我不能在这里发布)我正在研究并且在调用等效的时候产生异常Foo::stop().valgrind警告是否意味着我对C++线程接口有一些严重的误解？并假设片刻Foo::run实际上会做一些有用的事情,我怎么能修复这个程序,同时保持Foo接口的方式呢？

Answer 1

什么是初始值bool done;？它是不确定的(一些垃圾值),所以你的thread(run)可以在没有调用stop方法的情况下停止.

done 必须初始化:

  //...
  std::mutex mutex;
  bool done = false; // <--