PHP - 简单的重构

Question

我有以下代码:

$image_1 = $value->getElementsByTagName("Image1");
$image1  = $image_1->item(0)->nodeValue;

$image_2 = $value->getElementsByTagName("Image2");
$image2  = $image_2->item(0)->nodeValue;

有没有更简单的方法,不重复代码如果我需要$ image_3？

即我怎么能重构这个？

谢谢

更新:

我在进一步的代码中使用$ images_x变量,这也需要重构:

更新2: - 我的完整代码:

$image_1 = $value->getElementsByTagName("Image1");
$image1  = $image_1->item(0)->nodeValue;

$image_2 = $value->getElementsByTagName("Image2");
$image2  = $image_2->item(0)->nodeValue;

$image_3 = $value->getElementsByTagName("Image3");
$image3  = $image_3->item(0)->nodeValue;

$filename_1 = basename($image1);
$ch = curl_init ($image1);
curl_setopt($ch, CURLOPT_HEADER, 0);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
curl_setopt($ch, CURLOPT_BINARYTRANSFER,1);
$rawdata_1=curl_exec ($ch);
curl_close ($ch);
$fp = fopen(Mage::getBaseDir('media') . DS . 'import/'.$filename_1,'w');
fwrite($fp, $rawdata_1);
fclose($fp);

$filename_2 = basename($image2);
$ch = curl_init ($image2);
curl_setopt($ch, CURLOPT_HEADER, 0);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
curl_setopt($ch, CURLOPT_BINARYTRANSFER,1);
$rawdata_2=curl_exec ($ch);
curl_close ($ch);
$fp = fopen(Mage::getBaseDir('media') . DS . 'import/'.$filename_2,'w');
fwrite($fp, $rawdata_2);
fclose($fp);

$filename_3 = basename($image3);
$ch = curl_init ($image3);
curl_setopt($ch, CURLOPT_HEADER, 0);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
curl_setopt($ch, CURLOPT_BINARYTRANSFER,1);
$rawdata_3=curl_exec ($ch);
curl_close ($ch);
$fp = fopen(Mage::getBaseDir('media') . DS . 'import/'.$filename_3,'w');
fwrite($fp, $rawdata_3);
fclose($fp);

$product->addImageToMediaGallery(Mage::getBaseDir('media') . DS . 'import/' .  $filename_1, array('image', 'small_image','thumbnail'), false, false);
$product->addImageToMediaGallery(Mage::getBaseDir('media') . DS . 'import/' .  $filename_2, array('image', 'small_image','thumbnail'), false, false);
$product->addImageToMediaGallery(Mage::getBaseDir('media') . DS . 'import/' .  $filename_3, array('image', 'small_image','thumbnail'), false, false);

Answer 1

你可以使用循环:

$images = array();
for ($i = 1; $i <= 2; $i++) {
   $images[] = $value->getElementsByTagName("Image" . $i)->item(0)->nodeValue;
}

// and then you can get an image via $images[0], $images[1] and so on

所有代码都可以重写为Brad F Jacobs建议:

function downloadAndSave($image) {
    $filename = basename($image);
    $ch = curl_init ($image);
    curl_setopt($ch, CURLOPT_HEADER, 0);
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
    curl_setopt($ch, CURLOPT_BINARYTRANSFER,1);
    $rawdata=curl_exec ($ch);
    curl_close ($ch);
    $fp = fopen(Mage::getBaseDir('media') . DS . 'import/'.$filename,'w');
    fwrite($fp, $rawdata);
    fclose($fp);
    return $filename;
}
// here you should have another loop, suppose foreach ($products as $product) {
    for ($i = 1; $i <= 2; $i++) {
       $filename = downloadAndSave($value->getElementsByTagName("Image" . $i)->item(0)->nodeValue);
       $product->addImageToMediaGallery(Mage::getBaseDir('media') . DS . 'import/' .  $filename, array('image', 'small_image','thumbnail'), false, false);
    }
// end of foreach }