iOS 10 - 在deinit上发生NSKeyValueObservation崩溃

mrf*_*our 5 key-value-observing swift ios10 swift4

NSKeyValueObservation用来观察子类中的属性WKWebView.

它在iOS 11上运行良好,但deinit在iOS 10上崩溃.


控制台上的打印错误日志

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'An instance 0x15209e600 of class Rakuemon.WebView was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x170232da0> (
<NSKeyValueObservance 0x170259bf0: Observer: 0x17027d500, Key path: loading, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x170643ba0>
<NSKeyValueObservance 0x170643480: Observer: 0x170c72f80, Key path: estimatedProgress, Options: <New: YES, Old: NO, Prior: NO> Context: 0x0, Property: 0x170643330>
<NSKeyValueObservance 0x170642c70: Observer: 0x17086c0c0, Key path: title, Options: <New: YES, Old: NO, Prior: NO> Context: 0x0, Property: 0x1706437b0>
)'
Run Code Online (Sandbox Code Playgroud)

代码

class WebView: WKWebView {

    // MARK: - Properties

    weak var delegate: WebViewDelegate?

    // MARK: - Private properties

    private var contentSizeObserver: NSKeyValueObservation?
    private var loadingObserver: NSKeyValueObservation?
    private var estimatedProgressObserver: NSKeyValueObservation?
    private var titleObserver: NSKeyValueObservation?

    // MARK: - Life cycle

    override init(frame: CGRect, configuration: WKWebViewConfiguration) {
        super.init(frame: frame, configuration: configuration)
        setupObserver()
    }

    required init?(coder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
}

// MARK: - Private functions

private extension WebView {
    func setupObserver() {
        contentSizeObserver = scrollView.observe(\.contentSize, options: [.old, .new], changeHandler: { [unowned self] _, change in
            guard let oldSize = change.oldValue, let newSize = change.newValue, oldSize != newSize else { return }
            self.delegate?.webView?(self, didChangeSizeFrom: oldSize, to: newSize)
        })

        loadingObserver = observe(\.isLoading, changeHandler: { [unowned self] _, _ in
            self.delegate?.webViewIsLoading?(self)
        })

        estimatedProgressObserver = observe(\.estimatedProgress, options: [.new], changeHandler: { [unowned self] _, change in
            guard let newValue = change.newValue else { return }
            self.delegate?.webView?(self, didChangeEstimatedProgress: newValue)
        })

        titleObserver = observe(\.title, options: [.new], changeHandler: { [unowned self] _, change in
            guard let title = change.newValue else { return }
            self.delegate?.webView?(self, didChangeTitle: title ?? "")
        })
    }
}
Run Code Online (Sandbox Code Playgroud)

我还发现contentSizeObserver,观察到的scrollView.contentSize,不是属性self,没有导致崩溃.

那么,self通过iOS 10 观察其属性的正确方法是什么NSKeyValueObservation?或取消注册?

mrf*_*our 9

我最终弄清楚如何删除removeObserver(_:forKeyPath)iOS 10上的观察者.

// Environment: Xcode 11.1, Swift 5.1, iOS 10.3
deinit {
    if #available(iOS 11.0, *) {} else if let observer = observer {
        removeObserver(observer, forKeyPath: "foo")
    }
} 
Run Code Online (Sandbox Code Playgroud)


小智 5

看起来像苹果虫 – https://bugs.swift.org/browse/SR-5816

发生这种情况是因为 NSKeyValueObservation 持有对对象的弱引用。这个弱引用很快就变成了 nil。

在某些情况下,可以通过使用生命周期方法(viewDidDissapear 等)找到解决方法。在其他情况下,您应该使用旧的 obj-c api (addObserver / removeObserver / observeValue) 来支持 iOS 10。