Qua*_*eye 3 c++ stack-overflow recursion visual-c++
我是C++的新手但是认为在一些项目上工作Euler问题会让我熟悉这门语言.
我无法让我的C++解决方案工作,但我的python解决方案没有问题...
import time
start = time.time()
memo = {1:1,2:2}
longest_chain, longest_starting_key = 2, 2
def rec(a):
global longest_chain, longest_starting_key
if a in memo.keys():
return memo[a]
if a % 2 == 0:
memo[a] = rec(a // 2) + 1
else:
memo[a] = rec(3 * a + 1) + 1
if memo[a] > longest_chain:
longest_chain = memo[a]
longest_starting_key = a
return memo[a]
for i in range(1000000,3,-1): rec(i)
print("starting key", longest_starting_key , ": has length", longest_chain)
print((time.time() - start), "seconds")
Run Code Online (Sandbox Code Playgroud)
得到了
starting key 837799 has length 525
1.399820327758789 seconds
Run Code Online (Sandbox Code Playgroud)
我的C++尝试......(我认为是等同的...)
#include <iostream>
#include <unordered_map>
std::unordered_map<int, int> mem = { {1,1},{2,2} };
int longest_chain{ 2 }, best_starting_num{ 2 };
bool is_in(const int& i){
auto search = mem.find(i);
if(search == mem.end())
return false;
else
return true;
}
int f(int n){
if(is_in(n))
return mem[n];
if(n % 2)
mem[n] = f(3 * n + 1) + 1;
else
mem[n] = f(n / 2) + 1;
if(mem[n] > longest_chain)
longest_chain = mem[n];
return mem[n];
}
int main(){
for(int i = 3; i < 1000000; i++){
f(i);
}
std::cout << longest_chain << std::endl;
}
Run Code Online (Sandbox Code Playgroud)
在调试模式下在Visual Studio中运行时,我收到以下错误
Unhandled exception at 0x00007FF75A64EB70 in
0014_longest)collatz_sequence_cpp.exe: 0xC00000FD: Stack overflow
(parameters: 0x0000000000000001, 0x000000DC81493FE0).
Run Code Online (Sandbox Code Playgroud)
有人告诉我,我应该使用指针在堆上进行分配,但使用指针的经验非常有限......
另一件我不明白的是......当我在主体循环中使用100'000而不是1'000'000运行时,它可以工作但速度非常慢.