多个$ http.get请求w /每个JSON文件在HTML中被h1拆分

Question

我正在构建我的第一个Angular应用程序,使用$ http.get从github中提取原始json文件,每个json文件的输出在HTML中的标题之间分配.我的代码正在工作,但是非常冗余,我希望它可以被重构.

我的控制器看起来像这样:

.controller('mycontroller', function($scope, $http) {
  var firstUrl ='https://raw.githubusercontent.com/user/repo/master/first.json';
  var secondUrl ='https://raw.githubusercontent.com/user/repo/master/second.json';
  var thirdUrl ='https://raw.githubusercontent.com/user/repo/master/third.json';
  var fourthUrl ='https://raw.githubusercontent.com/user/repo/master/fourth.json';
  var fifthUrl ='https://raw.githubusercontent.com/user/repo/master/fifth.json';
  var sixthUrl ='https://raw.githubusercontent.com/user/repo/master/sixth.json';

  $http.get(firstUrl).success(function(data) {
      $scope.firsts = data;
  });

  $http.get(secondUrl).success(function(data) {
      $scope.seconds = data;
  });

  $http.get(thirdUrl).success(function(data) {
      $scope.thirds = data;
  });

  $http.get(fourthUrl).success(function(data) {
    $scope.fourths = data;
  });

  $http.get(fifthUrl).success(function(data) {
    $scope.fifths = data;
  });

  $http.get(sixthUrl).success(function(data) {
    $scope.sixths = data;
  });
});

我的HTML看起来像这样:

 <div ng-controller="mycontroller" id="content" class="container">
          <br/>
          <div ng-repeat="first in firsts" class="panel panel-default">
              <h1 id="first">first</h1>
              <div class="panel-heading">
                  <h1><a href="{{first.url}}">{{first.company}}</a></h1>
                  <p>{{first.address}}</p>
              </div>
                <div class="list-group">
              <a ng-repeat="position in first.positions" class="list-group-item" href="{{first.url}}">
                  {{position.title}}
              </a>
          </div>
         </div>
      </div>
      <div ng-controller="mycontroller" id="content" class="container">
          <h1 id="second">second</h1>
          <hr/>
          <div ng-repeat="second in seconds" class="panel panel-default">
              <div class="panel-heading">
                  <h1><a href="{{second.url}}">{{second.company}}</a></h1>
                  <p>{{second.address}}</p>
              </div>
          <div class="list-group">
              <a ng-repeat="position in second.positions" class="list-group-item" href="{{second.url}}">
                  {{position.title}}
              </a>
          </div>
         </div>
      </div>
      <div ng-controller="mycontroller" id="content" class="container">
          <h1 id="thirds">third</h1>
          <hr/>
          <div ng-repeat="third in thirds" class="panel panel-default">
              <div class="panel-heading">
                  <h1><a href="{{third.url}}">{{third.company}}</a></h1>
                  <p>{{third.address}}</p>
              </div>
          <div class="list-group">
              <a ng-repeat="position in third.positions" class="list-group-item" href="{{third.url}}">
                  {{position.title}}
              </a>
          </div>
        </div>
      </div>
      <div ng-controller="mycontroller" id="content" class="container">
          <h1 id="fourth">fourth</h1>
          <hr/>
          <div ng-repeat="fourth in fourths" class="panel panel-default">
              <div class="panel-heading">
                  <h1><a href="{{fourth.url}}">{{fourth.company}}</a></h1>
                  <p>{{fourth.address}}</p>
              </div>
          <div class="list-group">
              <a ng-repeat="position in fourth.positions" class="list-group-item" href="{{fourth.url}}">
                  {{position.title}}
              </a>
          </div>
      </div>
    </div>
      <div ng-controller="mycontroller" id="content" class="container">
          <h1 id="fifth">fifth</h1>
          <hr/>
          <div ng-repeat="fifth in fifths" class="panel panel-default">
              <div class="panel-heading">
                  <h1><a href="{{fifth.url}}">{{fifth.company}}</a></h1>
                  <p>{{fifth.address}}</p>
              </div>
          <div class="list-group">
              <a ng-repeat="position in fifth.positions" class="list-group-item" href="{{fifth.url}}">
                  {{position.title}}
              </a>
          </div>
      </div>
    </div>
      <div ng-controller="mycontroller" id="content" class="container">
          <h1 id="sixth">sixth</h1>
          <hr/>
          <div ng-repeat="sixth in fifths" class="panel panel-default">
              <div class="panel-heading">
                  <h1><a href="{{sixth.url}}">{{fifth.company}}</a></h1>
                  <p>{{sixth.address}}</p>
              </div>
          <div class="list-group">
              <a ng-repeat="position in sixth.positions" class="list-group-item" href="{{fifth.url}}">
                  {{position.title}}
              </a>
          </div>
      </div>
    </div>

Answer 1

你可以使用数组:

.controller('mycontroller', function($scope, $http, $q) {
    var urls = [
        'https://raw.githubusercontent.com/user/repo/master/first.json',
        'https://raw.githubusercontent.com/user/repo/master/second.json',
        'https://raw.githubusercontent.com/user/repo/master/third.json',
        'https://raw.githubusercontent.com/user/repo/master/fourth.json',
        'https://raw.githubusercontent.com/user/repo/master/fifth.json',
        'https://raw.githubusercontent.com/user/repo/master/sixth.json'
    ];

    var promises = urls.map(function(url) {
        return $http.get(url);
    });

    $q.all(promises).then(function(data) {
        // data will represent an array containing the response from all
        // AJAX requests
        $scope.data = data;
    });
});

并在data数组上的标记循环中:

<div ng-controller="mycontroller" ng-repeat="elements in data" class="container">
    <h1>{{$index}}</h1>
    <hr/>
    <div ng-repeat="item in elements" class="panel panel-default">
        <div class="panel-heading">
            <h1><a href="{{item.url}}">{{item.company}}</a></h1>
            <p>{{item.address}}</p>
        </div>
        <div class="list-group">
            <a ng-repeat="position in item.positions" class="list-group-item" href="{{item.url}}">
                {{position.title}}
            </a>
        </div>
    </div>
</div>