asp.net中的TDD新手,我是否在正确的轨道上编写测试？

Question

在过去的几个月里,我一直在阅读有关TDD的很多内容,并决定试着用一个简单的例子来试一试,我只是不确定我是否在实践中测试正确的东西.这里是用于验证电子邮件的自定义数据注释的测试:

using System;
using System.Text;
using System.Collections.Generic;
using System.Linq;
using Microsoft.VisualStudio.TestTools.UnitTesting;

namespace MembershipTest.Tests
{
    [TestClass]
    public class CustomDataAnnotationsTest
    {
        [TestMethod]
        public void CustomDataAnnotations_Email_ReturnTrueIfNull()
        {
            // Arrange
            EmailAttribute attribute = new EmailAttribute();

            // Act
            bool result = attribute.IsValid(null);

            // Assert
            Assert.AreEqual(true, result);
        }

        [TestMethod]
        public void CustomDataAnnotations_Email_ReturnFalseIfInvalid()
        {
            // Arrange
            EmailAttribute attribute = new EmailAttribute();

            // Act
            bool result = attribute.IsValid("()[]\\;:,<>@example.com");

            // Assert
            Assert.AreEqual(false, result);
        }

        [TestMethod]
        public void CustomDataAnnotations_Email_ReturnTrueIfValid()
        {
            // Arrange
            EmailAttribute attribute = new EmailAttribute();

            // Act
            bool result = attribute.IsValid("john.smith@example.com");

            // Assert
            Assert.AreEqual(true, result);
        }
    }
}

以下是为测试编写的后续代码:

using System;
using System.ComponentModel.DataAnnotations;
using System.Net.Mail;

public class EmailAttribute : ValidationAttribute
{
    public override bool IsValid(object value)
    {
        //Let RequiredAttribute validate whether the value is required or not.
        if (value == null)
        {
            return true;
        }

        //Check to see if System.Net.Mail can send to the address.
        try
        {
            var i = new MailAddress(value.ToString());
        }
        catch (Exception)
        {
            return false;
        }

        return true;
    }

}

所有测试最初都失败了,然后在编写代码后成功,但测试是否写得恰当？太多或太少？我知道这是一个非常简单的例子,但我想确保自己走上正确的轨道,然后才能开始更复杂的事情.

Answer 1

我认为你走在正确的轨道上.在这一点上,我建议你在测试中进行一些重构.因为你正在使用

EmailAttribute attribute = new EmailAttribute();

在每次测试中.我建议创建TestInitialize()和TestCleanup()方法.TestInitialize将新的EmailAttribute和TestCleanup将对象清空.这只是一个偏好问题.像这样

private EmailAttribute _attribute;

[TestInitialize]
public void TestInitialize()
{
  _attribute = new EmailAttribute
}

[TestCleanup]
public void TestCleanup()
{
  _attribute = null;
}