逻辑错误,在Tic Tac Toe中检查获胜者

Question

好吧,所以我非常接近完成这个计划.我理解为什么我的程序没有采取行动,我能够解决它,但现在我正在努力检查获胜者.我意识到我的winGame()功能应该在某种程度上或者在while循环中结束游戏.但是,当我试图做一些调试来解决一些问题时,我意识到一些令人不安的事情.它总是说它是一个平局,即使它不应该是.这些是很小的事情,我很惭愧,不理解,我真的希望得到一些帮助,我可以解决它.另外,我知道如果有胜利的话,应该有一段时间或者做while循环来结束游戏.我只是不确定在哪里放,所以如果您有任何建议,请告诉我.

*请注意,在我的有效移动函数中有一个小数组,我打算将其作为一个静态const数组.我的get函数返回名称中的值(例如getIval()返回单元格对象的初始值),而我的set函数只是适当地赋值.

bool TicTacToe::validMove(char move){
    char options[9] = { '1','2', '3', '4','5','6','7', '8','9' };
    bool validate = false;
    for ( int i = 0; i < 9; i++ ){
        if ( move == options[i]){
            validate = true;
        }
    }

    return ( validate );
}

void TicTacToe::setMove( char move ){
    for ( int i = 0; i < ROW; i++ ){
        for ( int j = 0; j < COL; j++ ){
            if ( board[i][j].getiVal() == move ){
                board[i][j].setiVal( players[currentPlayer].getMarker() );
                switchPlayer();
                break;
            }
        }
    }
}

void TicTacToe::makeAMove(){
    char move;
    int turns = 1;
    bool validate = true;

    do{
        cout << "Player " << (getCurrentPlayer() + 1) << " make a move." << endl;
        cin >> move;

        if ( validMove( move ) ){
            if ( turns > 4 ){
                cout << "Nested if-else statement." << endl;
                winGame();
                setMove( move );
            }
            else
                setMove(move);
        }
        else{
            cout << "Invalid Move. Please reenter." << endl;
            cin >> move;
        }

        DrawBoard();
        turns++;

    } while ( turns <= 9 );   
}

bool TicTacToe::winGame(){
    cout << "Calling winGame() "  << endl;
    bool validate = false;
    int k = 0;
    for ( int i = 0; i < COL; i++ ){
        //check column wins
        if ( board[0][i].getMarker() == board[1][i].getMarker() && board[1][i].getMarker() == board[2][i].getMarker() && board[2][i].getMarker() != (' ')){
            cout << "Column win " << endl;
            validate = true;
            break;
        }
        //check row wins
        else if ( board[i][0].getMarker() == board[i][1].getMarker() && board[i][1].getMarker() == board[i][2].getMarker() && board[i][2].getMarker() !=  (' ')){
            cout << "Row win." << endl;
            validate = true;
            break;
        }
    }

    if( board[0][0].getMarker() == board[1][1].getMarker() && board[1][1].getMarker() == board[2][2].getMarker() && board[2][2].getMarker() != (' ')){
        cout << "Diagonal 1" << endl;
        validate = true;
    }
    else if ( board[0][2].getMarker() == board[1][1].getMarker() && board[1][1].getMarker() == board[2][0].getMarker() && board[2][0].getMarker() != (' ') ){
        cout << "Diagonal 2 " << endl;
        validate = true;
    }
    else{
        cout << "It's a draw!" << endl;
        validate = true;
    }

    return (validate);
}

以下是该程序的示例运行供您参考.

    //sample run
+--+--+--+
|1 |2 |3 |
+--+--+--+
|4 |5 |6 |
+--+--+--+
|7 |8 |9 |
+--+--+--+
Player 1 make a move.
1

+--+--+--+
|X |2 |3 |
+--+--+--+
|4 |5 |6 |
+--+--+--+
|7 |8 |9 |
+--+--+--+
Player 2 make a move.
2

+--+--+--+
|X |O |3 |
+--+--+--+
|4 |5 |6 |
+--+--+--+
|7 |8 |9 |
+--+--+--+
Player 1 make a move.
3

+--+--+--+
|X |O |X |
+--+--+--+
|4 |5 |6 |
+--+--+--+
|7 |8 |9 |
+--+--+--+
Player 2 make a move.
5

+--+--+--+
|X |O |X |
+--+--+--+
|4 |O |6 |
+--+--+--+
|7 |8 |9 |
+--+--+--+
Player 1 make a move.
+--+--+--+
|X |O |X |
+--+--+--+
|4 |O |6 |
+--+--+--+
|7 |8 |9 |
+--+--+--+
Player 1 make a move.
7
Nested if-else statement.
Calling winGame()
It's a draw!

+--+--+--+
|X |O |X |
+--+--+--+
|4 |O |6 |
+--+--+--+
|X |8 |9 |
+--+--+--+
Player 2 make a move.
8
Nested if-else statement.
Calling winGame()
It's a draw!

+--+--+--+
|X |O |X |
+--+--+--+
|4 |O |6 |
+--+--+--+
|X |O |9 |
+--+--+--+

Answer 1

这段代码有3个问题。

1. 游戏循环并不因胜利而结束。
2. 胜利确认后，胜利函数不会立即返回。
3. 绘制条件的逻辑不正确。

不过这些很容易修复。

• 在 do-while 循环中如果 WinGame==true 则中断
• 使用 return validate 更改行和列胜利的中断

• Pass 变成了 WinGameme 函数，并做了一个额外的 if 语句来检查 ifturns==9

  void TicTacToe::makeAMove(){ 字符移动; 整数圈数 = 1；布尔验证=真；

      do{
              cout << "Player " << (getCurrentPlayer() + 1) << " make a move." << endl;
              cin >> move;
  
              if ( validMove( move ) ){
                      if ( turns > 4 ){
                              cout << "Nested if-else statement." << endl;
  
                              setMove( move );
                              if (winGame(turns)==true)
                              {
                                  break;
                              }
                      }
                      else
                              setMove(move);
              }
              else{
                      cout << "Invalid Move. Please reenter." << endl;
                      cin >> move;
              }
  
              DrawBoard();
              turns++;
  
      } while ( turns <= 9 );
      cout << "Game Over" <<endl;
  

  }

进而

bool TicTacToe::winGame(int turns)
{
        cout << "Calling winGame() "  << endl;
        bool validate = false;
        int k = 0;
        for ( int i = 0; i < COL; i++ )
        {
                //check column wins
            if ( board[0][i].getMarker() == board[1][i].getMarker() &&
                 board[1][i].getMarker() == board[2][i].getMarker() &&
                 board[2][i].getMarker() != (' ')){
                        cout << "Column win " << endl;
                        validate = true;
                        break;
                }
                //check row wins
                 else if ( board[i][0].getMarker() == board[i][1].getMarker() &&
                           board[i][1].getMarker() == board[i][2].getMarker() && 
                           board[i][2].getMarker() !=  (' ')){
                        cout << "Row win." << endl;
                        validate = true;
                        break;
                }
        }

        if( board[0][0].getMarker() == board[1][1].getMarker() && 
            board[1][1].getMarker() == board[2][2].getMarker() && 
            board[2][2].getMarker() != (' ')){
                cout << "Diagonal 1" << endl;
                validate = true;
        }
        else if ( board[0][2].getMarker() == board[1][1].getMarker() &&
                  board[1][1].getMarker() == board[2][0].getMarker() &&
                  board[2][0].getMarker() != (' ') ){
                cout << "Diagonal 2 " << endl;
                validate = true;
        }
        else
        {
            if (turns==9)
                {
                    cout << "It's a draw!" << endl;
                    validate = true;
                }
        }

        return (validate);
}