那些遇到过的问题

Rails 5 - 控制器规范示例 - 将params设置为nil值将其值设置为空字符串

Jig*_*hel 6 params ruby-on-rails-5

我有以下Controller规范示例传入基于Rails 4.2.0和Ruby 2.2.1的仅API应用程序

  let!(:params) { { user_token: user_token } }

  context "- and optional address and contact details params value are received as a nil values -" do
    it "doesn't set the address and contact details and responds with 201 success", check: true do
      params.merge!(
        address_street: nil, address_other: nil, city: nil, state: nil,
        zip_code: nil, phone: nil)

      post :create, params

      expect(response).to have_http_status(201)

      saved_client_id = json_response["id"]
      saved_client = Client.find_by(id: saved_client_id)
      expect(saved_client.address_street).to be_nil
      expect(saved_client.address_other).to be_nil
      expect(saved_client.city).to be_nil
      expect(saved_client.state).to be_nil
      expect(saved_client.zip_code).to be_nil
      expect(saved_client.phone).to be_nil
    end
  end
Run Code Online (Sandbox Code Playgroud)

但是,针对Rails 5(边缘版本)和Ruby 2.2.3评估我的应用程序时,相同的规范失败并出现以下错误:

  1) Api::V1::ClientsController POST #create when receives valid client details - and optional address and contact details params value are received as nil values - doesn't set the address and contact details and responds with 201 success
     Failure/Error: expect(saved_client.address_street).to be_nil
       expected: nil
            got: ""
     # ./spec/controllers/api/v1/clients_controller_spec.rb:352:in `block (5 levels) in <top (required)>'
     # ./spec/rails_helper.rb:61:in `block (3 levels) in <top (required)>'
     # /home/jignesh/.rvm/gems/ruby-2.2.3@myapp-on-rails-5/gems/database_cleaner-1.5.1/lib/database_cleaner/generic/base.rb:16:in `cleaning'
     # /home/jignesh/.rvm/gems/ruby-2.2.3@myapp-on-rails-5/gems/database_cleaner-1.5.1/lib/database_cleaner/base.rb:92:in `cleaning'
     # /home/jignesh/.rvm/gems/ruby-2.2.3@myapp-on-rails-5/gems/database_cleaner-1.5.1/lib/database_cleaner/configuration.rb:86:in `block (2 levels) in cleaning'
     # /home/jignesh/.rvm/gems/ruby-2.2.3@myapp-on-rails-5/gems/database_cleaner-1.5.1/lib/database_cleaner/configuration.rb:87:in `call'
     # /home/jignesh/.rvm/gems/ruby-2.2.3@myapp-on-rails-5/gems/database_cleaner-1.5.1/lib/database_cleaner/configuration.rb:87:in `cleaning'
 # ./spec/rails_helper.rb:60:in `block (2 levels) in <top (required)>'
Run Code Online (Sandbox Code Playgroud)

我确实在几个点检查了Rails源代码,发现在到达控制器的目标操作逻辑之前,nil值被转换为空值.

这种改变的行为是将属性设置为空字符串,当它们预期为零时.

在我的应用程序的Gemfile(使用Rails 5)中,我使用以下代码指定了Rails:

gem 'rails', git: 'https://github.com/rails/rails.git'

gem 'rack', :git => 'https://github.com/rack/rack.git'
gem 'arel', :git => 'https://github.com/rails/arel.git'
Run Code Online (Sandbox Code Playgroud)

并且在Gemfile.lock中可以看到以下内容(Gem和Dependencies部分被截断以缩短它):

GIT
  remote: git://github.com/capistrano/rbenv.git
  revision: 6f1216cfe0a6b4ac23ca4eaf8acf012e8165d247
  specs:
    capistrano-rbenv (2.0.3)
      capistrano (~> 3.1)
      sshkit (~> 1.3)

GIT
  remote: https://github.com/rack/rack.git
  revision: c393176b0edf3e5d06cabbb6eb9d9c7a07b2afa7
  specs:
    rack (2.0.0.alpha)
      json

GIT
  remote: https://github.com/rails/arel.git
  revision: 3c429c5d86e9e2201c2a35d934ca6a8911c18e69
  specs:
    arel (7.0.0.alpha)

GIT
  remote: https://github.com/rails/rails.git
  revision: 58df2f4b4abcce0b698c2540da215a565c24cbc9
  specs:
    actionmailer (5.0.0.alpha)
      actionpack (= 5.0.0.alpha)
      actionview (= 5.0.0.alpha)
      activejob (= 5.0.0.alpha)
      mail (~> 2.5, >= 2.5.4)
      rails-dom-testing (~> 1.0, >= 1.0.5)
    actionpack (5.0.0.alpha)
      actionview (= 5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      rack (~> 2.x)
      rack-test (~> 0.6.3)
      rails-dom-testing (~> 1.0, >= 1.0.5)
      rails-html-sanitizer (~> 1.0, >= 1.0.2)
    actionview (5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      builder (~> 3.1)
      erubis (~> 2.7.0)
      rails-dom-testing (~> 1.0, >= 1.0.5)
      rails-html-sanitizer (~> 1.0, >= 1.0.2)
    activejob (5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      globalid (>= 0.3.0)
    activemodel (5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      builder (~> 3.1)
    activerecord (5.0.0.alpha)
      activemodel (= 5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      arel (= 7.0.0.alpha)
    activesupport (5.0.0.alpha)
      concurrent-ruby (~> 1.0)
      i18n (~> 0.7)
      json (~> 1.7, >= 1.7.7)
      method_source
      minitest (~> 5.1)
      tzinfo (~> 1.1)
    rails (5.0.0.alpha)
      actionmailer (= 5.0.0.alpha)
      actionpack (= 5.0.0.alpha)
      actionview (= 5.0.0.alpha)
      activejob (= 5.0.0.alpha)
      activemodel (= 5.0.0.alpha)
      activerecord (= 5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      bundler (>= 1.3.0, < 2.0)
      railties (= 5.0.0.alpha)
      sprockets-rails (>= 2.0.0)
    railties (5.0.0.alpha)
      actionpack (= 5.0.0.alpha)
      activesupport (= 5.0.0.alpha)
      method_source
      rake (>= 0.8.7)
      thor (>= 0.18.1, < 2.0)
...
....
Run Code Online (Sandbox Code Playgroud)

任何人都可以让我知道是什么改变造成的吗？我想这与Rails 5或最新Rack中的更改有关.这是某种类型的错误,应该在最终版本中修复,或者这是故意更改.

Jig*_*hel 9

我找到了上述行为的根本原因:在Rails 5中,它是由ActionController :: TestRequest #assign_parameters方法CONTENT_TYPE设置的默认头引起的'application/x-www-form-urlencoded',但是在Rails 4.2.0中并非如此.

以下是关于我如何得出结论的详细调查结果:

在规范示例中传递的params(在我的问题帖子中显示)的上下文中,Rails 5(及其Rack版本)和Rails 4.2.0(及其Rack版本)的执行流程如下所述:

Rails 5

ActionPack的/ lib目录/ action_dispatch/http_request.rb#form_data？返回true

actionpack/lib/action_dispatch/http_request.rb #POST方法如下所示:

# Override Rack's POST method to support indifferent access
def POST
  fetch_header("action_dispatch.request.request_parameters") do
    pr = parse_formatted_parameters(params_parsers) do |params|
      super || {}
    end
    self.request_parameters = Request::Utils.normalize_encode_params(pr)
  end
rescue ParamsParser::ParseError # one of the parse strategies blew up
  self.request_parameters = Request::Utils.normalize_encode_params(super || {})
  raise
rescue Rack::Utils::ParameterTypeError, Rack::Utils::InvalidParameterError => e
  raise ActionController::BadRequest.new("Invalid request parameters: #{e.message}")
end
alias :request_parameters :POST
Run Code Online (Sandbox Code Playgroud)

在尝试评估时fetch_header("action_dispatch.request.request_parameters")运行默认值块,super该块调用使调用转到Rack的请求(/rack-c393176b0edf/lib/rack/request.rb)POST方法.我在下面用几个调试语句展示了这个方法的代码:

机架/ lib目录/架/ request.rb#POST

  # Returns the data received in the request body.
  #
  # This method support both application/x-www-form-urlencoded and
  # multipart/form-data.
  def POST
    puts ">>>>>>>>>>> DEBUG 2"
    if get_header(RACK_INPUT).nil?
      puts ">>>>>>>>>>> DEBUG 2.1"
      raise "Missing rack.input"
    elsif get_header(RACK_REQUEST_FORM_INPUT) == get_header(RACK_INPUT)
      puts ">>>>>>>>>>> DEBUG 2.2"
      get_header(RACK_REQUEST_FORM_HASH)
    elsif form_data? || parseable_data?
      puts ">>>>>>>>>>> DEBUG 2.3"
      unless set_header(RACK_REQUEST_FORM_HASH, parse_multipart)
        form_vars = get_header(RACK_INPUT).read

        # Fix for Safari Ajax postings that always append \0
        # form_vars.sub!(/\0\z/, '') # performance replacement:
        form_vars.slice!(-1) if form_vars[-1] == ?\0

        set_header RACK_REQUEST_FORM_VARS, form_vars
        set_header RACK_REQUEST_FORM_HASH, parse_query(form_vars, '&')
        get_header(RACK_INPUT).rewind
      end
      set_header RACK_REQUEST_FORM_INPUT, get_header(RACK_INPUT)
      get_header RACK_REQUEST_FORM_HASH
    else
      puts ">>>>>>>>>>> DEBUG 2.4"
      {}
    end
Run Code Online (Sandbox Code Playgroud)

使用这些调试语句,执行流程以">>>>>>>>>>> DEBUG 2.3"结束.在那里,我还检查了get_header RACK_REQUEST_FORM_HASH并打印出来

>>>>>>>>>>> get_header RACK_REQUEST_FORM_HASH: {"address_other"=>"", "address_street"=>"", "city"=>"", "client_residence_type_id"=>"", "name"=>"Test Client 1", "phone"=>"", "provider_id"=>"64", "state"=>"", "zip_code"=>""}
Run Code Online (Sandbox Code Playgroud)

所以它的parse_query(form_vars, '&')方法是将nil值转换为空字符串.

Rails 4.2.0

ActionPack的/ lib目录/ action_dispatch/http_request.rb#form_data？返回false

actionpack/lib/action_dispatch/http_request.rb #POST方法如下所示:

# Override Rack's POST method to support indifferent access
def POST
  @env["action_dispatch.request.request_parameters"] ||= Utils.deep_munge(normalize_encode_params(super || {}))
rescue Rack::Utils::ParameterTypeError, Rack::Utils::InvalidParameterError => e
  raise ActionController::BadRequest.new(:request, e)
end
alias :request_parameters :POST
Run Code Online (Sandbox Code Playgroud)

这调用super使调用转到Rack的Request(rack-1.6.4/lib/rack/request.rb)POST方法.我在下面用几个调试语句展示了这个方法的代码:

机架1.6.4/lib中/架/ request.rb#parseable_data？返回false

rack-1.6.4/lib/rack/request.rb #POST流程结束于">>>>>>>>>>> DEBUG 2.4"

def POST
  puts ">>>>>>>>>>> DEBUG 2"
  if @env["rack.input"].nil?
    puts ">>>>>>>>>>> DEBUG 2.1"
    raise "Missing rack.input"
  elsif @env["rack.request.form_input"].equal? @env["rack.input"]
    puts ">>>>>>>>>>> DEBUG 2.2"
    @env["rack.request.form_hash"]
  elsif form_data? || parseable_data?
    puts ">>>>>>>>>>> DEBUG 2.3"
    unless @env["rack.request.form_hash"] = parse_multipart(env)
      form_vars = @env["rack.input"].read

      # Fix for Safari Ajax postings that always append \0
      # form_vars.sub!(/\0\z/, '') # performance replacement:
      form_vars.slice!(-1) if form_vars[-1] == ?\0

      @env["rack.request.form_vars"] = form_vars
      @env["rack.request.form_hash"] = parse_query({ :query => form_vars, :separator => '&' })

      @env["rack.input"].rewind
    end
    @env["rack.request.form_input"] = @env["rack.input"]
    @env["rack.request.form_hash"]
  else
    puts ">>>>>>>>>>> DEBUG 2.4"
    {}
  end
end
Run Code Online (Sandbox Code Playgroud)

这引起了我的注意,在content_mime_type内部使用的Rails 5 中form_data?设置了,因此规范示例提交的参数被解析为形式参数.

但是在Rails 4.2.0 content_mime_type中没有找到不会导致提交的参数被解析为form_params的集合.

Rails 4.2.0

该content_mime_type方法在ActionDispatch::Http::MimeNegotiation模块中定义

  def content_mime_type
    @env["action_dispatch.request.content_type"] ||= begin
      if @env['CONTENT_TYPE'] =~ /^([^,\;]*)/
        Mime::Type.lookup($1.strip.downcase)
      else
        nil
      end
    end
  end
Run Code Online (Sandbox Code Playgroud)

返回零

Rails 5

该content_mime_type方法在ActionDispatch::Http::MimeNegotiation模块中定义

  def content_mime_type
    fetch_header("action_dispatch.request.content_type") do |k|
      v = if get_header('CONTENT_TYPE') =~ /^([^,\;]*)/
        Mime::Type.lookup($1.strip.downcase)
      else
        nil
      end
      set_header k, v
    end
  end
Run Code Online (Sandbox Code Playgroud)

在这种情况下if get_header('CONTENT_TYPE') =~ /^([^,\;]*)/,评估为true,因此Mime::Type.lookup($1.strip.downcase)返回

Rails 4.2.0

标题CONTENT_TYPE不会被设置

actionpack/lib/action_controller/test_case.rb#def assign_parameters(routes,controller_path,action,parameters = {})方法

def assign_parameters(routes, controller_path, action, parameters = {})
  parameters = parameters.symbolize_keys.merge(:controller => controller_path, :action => action)
  extra_keys = routes.extra_keys(parameters)
  non_path_parameters = get? ? query_parameters : request_parameters
  parameters.each do |key, value|
    if value.is_a?(Array) && (value.frozen? || value.any?(&:frozen?))
      value = value.map{ |v| v.duplicable? ? v.dup : v }
    elsif value.is_a?(Hash) && (value.frozen? || value.any?{ |k,v| v.frozen? })
      value = Hash[value.map{ |k,v| [k, v.duplicable? ? v.dup : v] }]
    elsif value.frozen? && value.duplicable?
      value = value.dup
    end

    if extra_keys.include?(key)
      non_path_parameters[key] = value
    else
      if value.is_a?(Array)
        value = value.map(&:to_param)
      else
        value = value.to_param
      end

      path_parameters[key] = value
    end
  end

  # Clear the combined params hash in case it was already referenced.
  @env.delete("action_dispatch.request.parameters")

  # Clear the filter cache variables so they're not stale
  @filtered_parameters = @filtered_env = @filtered_path = nil

  params = self.request_parameters.dup
  %w(controller action only_path).each do |k|
    params.delete(k)
    params.delete(k.to_sym)
  end
  data = params.to_query

  @env['CONTENT_LENGTH'] = data.length.to_s
  @env['rack.input'] = StringIO.new(data)
end
Run Code Online (Sandbox Code Playgroud)

Rails 5

标题CONTENT_TYPE由设置

actionpack/lib/action_controller/test_case.rb #assign_parameters(routes,controller_path,action,parameters,generated_pa​​th,query_string_keys)方法

def assign_parameters(routes, controller_path, action, parameters, generated_path, query_string_keys)
  non_path_parameters = {}
  path_parameters = {}

  parameters.each do |key, value|
    if query_string_keys.include?(key)
      non_path_parameters[key] = value
    else
      if value.is_a?(Array)
        value = value.map(&:to_param)
      else
        value = value.to_param
      end

      path_parameters[key] = value
    end
  end

  if get?
    if self.query_string.blank?
      self.query_string = non_path_parameters.to_query
    end
  else
    if ENCODER.should_multipart?(non_path_parameters)
      self.content_type = ENCODER.content_type
      data = ENCODER.build_multipart non_path_parameters
    else
      fetch_header('CONTENT_TYPE') do |k|
        set_header k, 'application/x-www-form-urlencoded'
      end

      case content_mime_type.to_sym
      when nil
        raise "Unknown Content-Type: #{content_type}"
      when :json
        data = ActiveSupport::JSON.encode(non_path_parameters)
      when :xml
        data = non_path_parameters.to_xml
      when :url_encoded_form
        data = non_path_parameters.to_query
      else
        @custom_param_parsers[content_mime_type] = ->(_) { non_path_parameters }
        data = non_path_parameters.to_query
      end
    end

    set_header 'CONTENT_LENGTH', data.length.to_s
    set_header 'rack.input', StringIO.new(data)
  end

  fetch_header("PATH_INFO") do |k|
    set_header k, generated_path
  end
  path_parameters[:controller] = controller_path
  path_parameters[:action] = action

  self.path_parameters = path_parameters
end
Run Code Online (Sandbox Code Playgroud)

可以看出POST请求后面的代码被执行,它将CONTENT_TYPE标头设置为默认值'application/x-www-form-urlencoded'

      fetch_header('CONTENT_TYPE') do |k|
        set_header k, 'application/x-www-form-urlencoded'
      end
Run Code Online (Sandbox Code Playgroud)

谢谢.

小智 7

看起来这个问题已知但尚未修复.本期中提到了一种解决方法:https://github.com/rspec/rspec-rails/issues/1655

我在我的rspec控制器测试中测试并使用了它,它正确地发送数据:

before { request.env['CONTENT_TYPE'] = 'application/json' }

归档时间：

查看次数：

2443 次

最近记录：

8 年，8 月 前
相关归档
Grails - 在参数图中添加参数 7
Rails 5 - 任何人都可以解释如何从未经过清理的请求参数生成URL是不安全的吗？ 6
RAILS:Bundler在安装ActiveAdmin时找不到gem"actionpack"的兼容版本 5
带有 remotipart 的 Rails 5 ajax 上传文件不起作用（作为 HTML 而不是 JS 发送） 5
电子邮件模板中的动态内容 5
如何在 Elastic Beanstalk 容器中提供 Rails 应用程序的 webpacked 资产？ 5
Rails - 使用与自定义命名关联的连接 3
返回 jsonb 列数组计数大于给定值的 activerecord 结果 3
如何在 ActionCable Channel 中获取 request.session？ 3
从查询字符串中获取参数 0
难疑归档
Flash CS4拒绝放手 2735
有没有办法对字符串进行子串？ 1995
如何计算C#中某人的年龄？ 1754
什么是尾递归？ 1602
将文件从主机复制到Docker容器 1391
vim"用sudo写"技巧如何工作？ 1347
你如何在YAML中阻止评论？ 1272
哪个MySQL数据类型用于存储布尔值 1168
将先前的提交分解为多个提交 1113
如何将div的内容与底部对齐？ 1098