通过尝试选择排序实现来获取分段错误*有时*

Question

我试图自己调试这个,但我无法弄清楚!在运行我的代码时,我有时会遇到分段错误,当没有seg错误时,它运行得很好并且有效.任何指导将不胜感激,谢谢!另外,请记住我是C++的新手.

这是我到目前为止所拥有的:

#include <iostream>
#include <vector>
using namespace std;

vector<int> selection_sort(vector<int> numbers) {
    int lowest_number_index;
    int lowest_number;
    int starting_size = numbers.size();
    vector<int> sorted_numbers;
    for (int i = 0; i < numbers.size(); ++i) {

        // Find the lowest number
        if (numbers[i] <= lowest_number) {
            lowest_number_index = i;
            lowest_number = numbers[lowest_number_index];
        }

        // Found it! Now let's add it to the other array
        // and remove it from this one.
        if (i == numbers.size() - 1 && numbers.size() != 1) {
            sorted_numbers.push_back(lowest_number);
            numbers.erase(numbers.begin() + lowest_number_index);

            // If we're not done sorting
            if (sorted_numbers.size() != starting_size) {
                lowest_number_index = 0;
                lowest_number = numbers[lowest_number_index];
                // Continue sorting
                i = -1;
                continue;
            }
        } else if (numbers.size() == 1) {
            sorted_numbers.push_back(numbers[i]);
        }
    }

    return sorted_numbers;
}

int main() {
    vector<int> to_sort { 15, 2, 41, 5, 4, 5, 4, 6 };
    to_sort = selection_sort(to_sort);

    cout << "Sorted: ";
    for (auto it = to_sort.begin(); it != to_sort.end(); ++it) {
        cout << *it << " ";
    }
    cout << endl;
}

Answer 1

该函数具有未定义的行为,因为使用了未初始化的变量 lowest_number

int lowest_number;
     ^^^^^^^^^^^^^
//...
for (int i = 0; i < numbers.size(); ++i) {

    // Find the lowest number
    if (numbers[i] <= lowest_number) {
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 

考虑到变量lowest_number_index也未初始化.

int lowest_number_index;