那些遇到过的问题

我该如何改进？

Ste*_*eve 1 ruby

我想知道是否有人能够指出一种更清洁的更好的方法来编写粘贴在这里的代码.代码从yelp中删除一些数据并将其处理为json格式.我没有使用的原因hash.to_json是因为它抛出某种堆栈错误,我只能假设是由于散列太大(它不是特别大).

  • 响应对象=哈希
  • text =保存到文件的输出

无论如何指导赞赏. 

def mineLocation

  client = Yelp::Client.new
  request = Yelp::Review::Request::GeoPoint.new(:latitude=>13.3125,:longitude => -6.2468,:yws_id => 'nicetry')
  response = client.search(request) 
  response['businesses'].length.times do |businessEntry|
    text =""
     response['businesses'][businessEntry].each { |key, value|
        if value.class == Array 
          value.length.times { |arrayEntry|
            text+= "\"#{key}\":["
             value[arrayEntry].each { |arrayKey,arrayValue|
              text+= "{\"#{arrayKey}\":\"#{arrayValue}\"},"
             }
             text+="]"   
          }
        else 
              text+="\"#{arrayKey}\":\"#{arrayValue}\"," 
        end
       }
  end
 end
Run Code Online (Sandbox Code Playgroud)

Jör*_*tag 8

看起来你的所有代码最终都是这样的:

require 'json'

def mine_location
  client = Yelp::Client.new
  request = Yelp::Review::Request::GeoPoint.new(latitude: 13.3125,
    longitude: -6.2468, yws_id: 'nicetry')
  response = client.search(request)

  return response['businesses'].to_json
end
Run Code Online (Sandbox Code Playgroud)

哪个对我来说很好.

如果由于某种原因你真的必须编写自己的JSON发射器实现,这里有几个提示.

您在代码中完全忽略的第一件事是Ruby是一种面向对象的语言,更具体地说是一种基于类的面向对象语言.这意味着通过构建通过消息传递相互通信的对象网络来解决问题,并通过执行这些对象所属的类中定义的方法来响应这些消息.

这为我们提供了很多动力:动态调度,多态,封装和其他许多功能.利用这些,您的JSON发射器看起来像这样:

class Object
  def to_json; to_s                                                         end
end

class NilClass
  def to_json; 'null'                                                       end
end

class String
  def to_json; %Q'"#{to_s}"'                                                end
end

class Array
  def to_json; "[#{map(&:to_json).join(', ')}]"                             end
end

class Hash
  def to_json; "{#{map {|k, v| "#{k.to_json}: #{v.to_json}" }.join(', ')}}" end
end
Run Code Online (Sandbox Code Playgroud)

mine_location看起来就像上面一样,除了显然没有require 'json'部分.

如果你想要你的JSON格式很好,你可以尝试这样的事情:

class Object
  def to_json(*) to_s    end
end

class String
  def to_json(*) inspect end
end

class Array
  def to_json(indent=0)
    "[\n#{'  ' * indent+=1}#{
      map {|el| el.to_json(indent) }.join(", \n#{'  ' * indent}")
    }\n#{'  ' * indent-=1}]"
  end
end

class Hash
  def to_json(indent=0)
    "{\n#{'  ' * indent+=1}#{
      map {|k, v|
        "#{k.to_json(indent)}: #{v.to_json(indent)}"
      }.join(", \n#{'  ' * indent}")
    }\n#{'  ' * indent-=1}}"
  end
end
Run Code Online (Sandbox Code Playgroud)

实际上在这段代码中没有特定于Ruby的东西.这是非常准确的解决方案是什么样子像Java任何其他基于类的面向对象的语言,例如.它只是面向对象的设计101.

唯一特定于语言的是如何"修改"类并向其添加方法.在Ruby或Python中,您只需修改类.在C#和Visual Basic.NET中,您可能会使用扩展方法,在Scala中您将使用隐式转换,在Java中可能使用Decorator设计模式.

您的代码的另一个巨大问题是您正在尝试解决一个明显递归但实际上没有递归的问题.这只是不能正常工作.你编写的代码基本上是Fortran-57代码:没有对象且没有递归的程序.即使只是移动一个从Fortran语言的一步,比方说,帕斯卡尔,为您提供了一个很好的递归程序解决方案:

def jsonify(o)
  case o
  when Hash
    "{#{o.map {|k, v| "#{jsonify(k)}: #{jsonify(v)}" }.join(', ')}}"
  when Array
    "[#{o.map(&method(:jsonify)).join(', ')}]"
  when String
    o.inspect
  when nil
    'null'
  else
    o.to_s
  end
end
Run Code Online (Sandbox Code Playgroud)

当然,你可以在这里用缩进玩同一个游戏:

def jsonify(o, indent=0)
  case o
  when Hash
    "{\n#{'  ' * indent+=1}#{
      o.map {|k, v|
        "#{jsonify(k, indent)}: #{jsonify(v, indent)}"
      }.join(", \n#{'  ' * indent}") }\n#{'  ' * indent-=1}}"
  when Array
    "[\n#{'  ' * indent+=1}#{
      o.map {|el| jsonify(el, indent) }.join(", \n#{'  ' * indent}") }\n#{'  ' * indent-=1}]"
  when String
    o.inspect
  when nil
    'null'
  else
    o.to_s
  end
end
Run Code Online (Sandbox Code Playgroud)

这是puts mine_location使用第二个(缩进)版本to_json或第二个版本生成的缩进输出jsonify,它并不重要,它们都具有相同的输出:

[
  {
    "name": "Nickies",
    "mobile_url": "http://mobile.yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ",
    "city": "San Francisco",
    "address1": "466 Haight St",
    "zip": "94117",
    "latitude": 37.772201,
    "avg_rating": 4.0,
    "address2": "",
    "country_code": "US",
    "country": "USA",
    "address3": "",
    "photo_url_small": "http://static.px.yelp.com/bpthumb/mPNTiQm5HVqLLcUi8XrDiA/ss",
    "url": "http://yelp.com/biz/nickies-san-francisco",
    "photo_url": "http://static.px.yelp.com/bpthumb/mPNTiQm5HVqLLcUi8XrDiA/ms",
    "rating_img_url_small": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_small_4.png",
    "is_closed": false,
    "id": "yyqwqfgn1ZmbQYNbl7s5sQ",
    "nearby_url": "http://yelp.com/search?find_loc=466+Haight+St%2C+San+Francisco%2C+CA",
    "state_code": "CA",
    "reviews": [
      {
        "rating": 3,
        "user_photo_url_small": "http://static.px.yelp.com/upthumb/ZQDXkIwQmgfAcazw8OgK2g/ss",
        "url": "http://yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ#hrid:t-sisM24K9GvvYhr-9w1EQ",
        "user_url": "http://yelp.com/user_details?userid=XMeRHjiLhA9cv3BsSOazCA",
        "user_photo_url": "http://static.px.yelp.com/upthumb/ZQDXkIwQmgfAcazw8OgK2g/ms",
        "rating_img_url_small": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_small_3.png",
        "id": "t-sisM24K9GvvYhr-9w1EQ",
        "text_excerpt": "So I know gentrification is supposed to be a bad word and all (especially here in SF), but the Lower Haight might benefit a bit from it. At least, I like...",
        "user_name": "Trey F.",
        "mobile_uri": "http://mobile.yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ?srid=t-sisM24K9GvvYhr-9w1EQ",
        "rating_img_url": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_3.png"
      },
      {
        "rating": 4,
        "user_photo_url_small": "http://static.px.yelp.com/upthumb/Ghwoq23_alkaXawgqj7dBA/ss",
        "url": "http://yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ#hrid:8xTNOC9L5ZXwGCMNYY-pdQ",
        "user_url": "http://yelp.com/user_details?userid=4F2QG3adYIUNXplqqp9ylA",
        "user_photo_url": "http://static.px.yelp.com/upthumb/Ghwoq23_alkaXawgqj7dBA/ms",
        "rating_img_url_small": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_small_4.png",
        "id": "8xTNOC9L5ZXwGCMNYY-pdQ",
        "text_excerpt": "This place was definitely a great place to chill. The atmosphere is very non-threatening and very neighborly. I thought it was cool that they had a girl dj...",
        "user_name": "Jessy M.",
        "mobile_uri": "http://mobile.yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ?srid=8xTNOC9L5ZXwGCMNYY-pdQ",
        "rating_img_url": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_4.png"
      },
      {
        "rating": 5,
        "user_photo_url_small": "http://static.px.yelp.com/upthumb/q0POOE3vv2LzNg1qN8MMyw/ss",
        "url": "http://yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ#hrid:pp33WfN_FoKlQKJ-38j_Ag",
        "user_url": "http://yelp.com/user_details?userid=FmcKafW272uSWXbUF2rslA",
        "user_photo_url": "http://static.px.yelp.com/upthumb/q0POOE3vv2LzNg1qN8MMyw/ms",
        "rating_img_url_small": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_small_5.png",
        "id": "pp33WfN_FoKlQKJ-38j_Ag",
        "text_excerpt": "Love this place!  I've been here twice now and each time has been a great experience.  The bartender is so nice.  When we had questions about the drinks he...",
        "user_name": "Scott M.",
        "mobile_uri": "http://mobile.yelp.com/biz/yyqwqfgn1ZmbQYNbl7s5sQ?srid=pp33WfN_FoKlQKJ-38j_Ag",
        "rating_img_url": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_5.png"
      }
    ],
    "phone": "4152550300",
    "neighborhoods": [
      {
        "name": "Hayes Valley",
        "url": "http://yelp.com/search?find_loc=Hayes+Valley%2C+San+Francisco%2C+CA"
      }
    ],
    "rating_img_url": "http://static.px.yelp.com/static/20070816/i/ico/stars/stars_4.png",
    "longitude": -122.429926,
    "categories": [
      {
        "name": "Dance Clubs",
        "category_filter": "danceclubs",
        "search_url": "http://yelp.com/search?find_loc=466+Haight+St%2C+San+Francisco%2C+CA&cflt=danceclubs"
      },
      {
        "name": "Lounges",
        "category_filter": "lounges",
        "search_url": "http://yelp.com/search?find_loc=466+Haight+St%2C+San+Francisco%2C+CA&cflt=lounges"
      },
      {
        "name": "American (Traditional)",
        "category_filter": "tradamerican",
        "search_url": "http://yelp.com/search?find_loc=466+Haight+St%2C+San+Francisco%2C+CA&cflt=tradamerican"
      }
    ],
    "state": "CA",
    "review_count": 32,
    "distance": 1.87804019451141
  }
]
Run Code Online (Sandbox Code Playgroud)

bra*_*rad 8

我注意到的第一件事就是你的使用 

response['businesses'].length.times do |i|
  # the business you want is response['businesses'][i]
end
Run Code Online (Sandbox Code Playgroud)

用于迭代.使用Array.each可以大大简化这一过程,它为您提供:

response['businesses'].each do |businessEntry|
  # here, businessEntry is the actual object, so forego something like
  # response['business'][businessEntry], just use businessEntry directly
end
Run Code Online (Sandbox Code Playgroud)

你实际上在下面做了同样的事情:response ['business'] [businessEntry] .each

关于样式的注意事项,如果块在多行上,常常(虽然没有强制执行)常用样式使用do/end,如果块是一行,则使用{}.

另外,不确定为什么要在字符串中构建这些键/值对,只需要进行哈希.然后你可以很容易地转换为json,或者正如Jorg指出的那样,只需将整个响应转换为json,它完全可以手动完成你所做的事情......除非你需要先处理数据(它看起来不像你需要这样做)

归档时间：

查看次数：

383 次

最近记录：

12 年，10 月 前
相关归档
在尝试保存大(ish)整数值时,获取指示数字的错误"超出ActiveRecord :: Type :: Integer且限制为4的范围" 28
执行gem时... ["extconf.rb",...]不是文件 18
Ruby的Hash和ActiveSupport的HashWithIndifferentAccess之间的区别 16
是否有可能'卸载'('un-require')Ruby库？ 13
用于.NET开发人员的Python或Ruby？ 12
{grape}授权 12
关于关系belongs_to的activerecord where子句 12
在测试套件上的HTTP不堪重负时,Elasticsearch不同步 12
与托尔互动提示 10
如何使用Ruby(和open-uri)并行处理数组中的项 10
难疑归档
为什么HTML认为"chucknorris"是一种颜色？ 7264
在'for'循环中访问索引？ 3312
Bower和npm有什么区别？ 1723
在JavaScript中修剪字符串？ 1285
Git diff对付藏匿处 1265
如何在JavaScript中合并两个数组并重复删除项目 1256
如何删除旧的Docker容器 1162
如何从另一个分支中获取一个文件 1154
Visual Studio中的构建解决方案,重建解决方案和清洁解决方案之间的区别？ 1081
致命错误:Python.h:没有这样的文件或目录 1042