使用 free() 和 realloc() 的错误

Ric*_*emp 2 c valgrind memory-leaks memory-movement

我写了一小段代码。我正在使用 void * 指针来为 C 的基本数据类型创建一个交换函数。我写了这个函数的两个版本,因为字符串与其他基本数据类型有点不同(但也许我错了)。这个函数的版本对于 int、float 和 char 它有效,但是当我尝试将一个用于字符串时,Valgrind 向我报告了多个错误。这是主要的:

int main(){

 int dimA=0,dimB=0;
 char *v,*g,*str1="heygv",*str2="bag";

 v=malloc(strlen(str1)+1);
 strcpy(v,str1);
 g=malloc(strlen(str2)+1);
 strcpy(g,str2);

 dimA=strlen(v);
 dimB=strlen(g);

 printf("\nX : %s %p ,Y : %s %p \n",v,v,g,g);
 swapStr(v,g,dimA+1,dimB+1);
 printf("\nX : %s %p ,Y : %s %p \n",v,v,g,g);

 free(v);
 free(g);

return 191;

}
Run Code Online (Sandbox Code Playgroud)

这是交换函数,它可以正常工作并正确交换字符串的值:

void* swapStr(void* a,void* b,int dimA,int dimB){

void* temp=malloc(dimA);
void* ptr;

    memcpy(temp,a,dimA);

    if(dimB>dimA){

        ptr=realloc(a,dimB);

        if(ptr==NULL){
            printf("\nError 1 realloc in swapStr\n");
            return;
        }else a=ptr;

    }

    memcpy(a,b,dimB);

    if(dimA>dimB){

        ptr=realloc(b,dimA);

        if(ptr==NULL){
            printf("\nError 2 realloc in swapStr\n");
            return;
        }else b=ptr;

    }

    memcpy(b,temp,dimA);

free(temp);
temp=NULL;
}
Run Code Online (Sandbox Code Playgroud)

这是 Valgrind 的报告:

X : heygv 0x51f2040 ,Y : bag 0x51f2090 
--5756-- REDIR: 0x4ec9080 (libc.so.6:memcpy@@GLIBC_2.14) redirected to 0x4a2472e (_vgnU_ifunc_wrapper)
--5756-- REDIR: 0x4ed1430 (libc.so.6:__memcpy_sse2_unaligned) redirected to 0x4c2e0d0 (memcpy@@GLIBC_2.14)
--5756-- REDIR: 0x4eb9ab0 (libc.so.6:realloc) redirected to 0x4c2ba52 (realloc)
--5756-- REDIR: 0x4eb8bb0 (libc.so.6:free) redirected to 0x4c2ac62 (free)

==5756== Invalid read of size 1
==5756==    at 0x4E7EC15: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2090 is 0 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== Invalid read of size 1
==5756==    at 0x4EAEBC1: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2092 is 2 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== Invalid read of size 1
==5756==    at 0x4EAEBD4: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2091 is 1 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== Invalid read of size 1
==5756==    at 0x4EC406B: __GI_mempcpy (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4EAEB0F: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2090 is 0 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== Invalid read of size 2
==5756==    at 0x4EC407B: __GI_mempcpy (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4EAEB0F: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2091 is 1 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
X : bag 0x51f2040 ,Y : bag 0x51f2090 
==5756== Invalid free() / delete / delete[] / realloc()
==5756==    at 0x4C2ACE9: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x40089D: main (swapVoid.c:49)
==5756==  Address 0x51f2090 is 0 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== 
==5756== HEAP SUMMARY:
==5756==     in use at exit: 6 bytes in 1 blocks
==5756==   total heap usage: 4 allocs, 4 frees, 22 bytes allocated
==5756== 
==5756== Searching for pointers to 1 not-freed blocks
==5756== Checked 65,256 bytes
==5756== 
==5756== 6 bytes in 1 blocks are definitely lost in loss record 1 of 1
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== LEAK SUMMARY:
==5756==    definitely lost: 6 bytes in 1 blocks
==5756==    indirectly lost: 0 bytes in 0 blocks
==5756==      possibly lost: 0 bytes in 0 blocks
==5756==    still reachable: 0 bytes in 0 blocks
==5756==         suppressed: 0 bytes in 0 blocks
==5756== 
==5756== ERROR SUMMARY: 11 errors from 7 contexts (suppressed: 0 from 0)
==5756== 
==5756== 1 errors in context 1 of 7:
==5756== Invalid free() / delete / delete[] / realloc()
==5756==    at 0x4C2ACE9: free (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x40089D: main (swapVoid.c:49)
==5756==  Address 0x51f2090 is 0 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== 
==5756== 1 errors in context 2 of 7:
==5756== Invalid read of size 2
==5756==    at 0x4EC407B: __GI_mempcpy (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4EAEB0F: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2091 is 1 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== 
==5756== 1 errors in context 3 of 7:
==5756== Invalid read of size 1
==5756==    at 0x4EC406B: __GI_mempcpy (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4EAEB0F: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2090 is 0 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== 
==5756== 1 errors in context 4 of 7:
==5756== Invalid read of size 1
==5756==    at 0x4EAEBC1: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2092 is 2 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== 
==5756== 2 errors in context 5 of 7:
==5756== Invalid read of size 1
==5756==    at 0x4EAEBD4: _IO_file_xsputn@@GLIBC_2.2.5 (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E7EBB5: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2091 is 1 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== 
==5756== 4 errors in context 6 of 7:
==5756== Invalid read of size 1
==5756==    at 0x4E7EC15: vfprintf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x4E88748: printf (in /usr/lib64/libc-2.20.so)
==5756==    by 0x400885: main (swapVoid.c:46)
==5756==  Address 0x51f2090 is 0 bytes inside a block of size 4 free'd
==5756==    at 0x4C2BB1C: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==5756==    by 0x400959: swapStr (swapVoid.c:77)
==5756==    by 0x400860: main (swapVoid.c:45)
==5756== 
==5756== ERROR SUMMARY: 11 errors from 7 contexts (suppressed: 0 from 0)
Run Code Online (Sandbox Code Playgroud)

错误似乎与 free ()(或 realloc ?) 的错误用法有关,但为什么呢?另一个奇怪的事实是,如果我在没有 valgrind 的情况下运行这个程序,它可以工作,而现在你看到字符串没有正确交换.

关于如何创建至少可以交换基本数据类型的交换函数,每一个可能的建议都被广泛接受。

Ted*_*val 5

您需要将指针传递给你的char*进入swapStr(),因为如果指针重新分配,你需要的字符串指针(char*)以指向新分配的内存。

例如。

void* swapStr(char **ap,char** bp,int dimA,int dimB){
    char *a = *ap;
    char *b = *bp;
    // ... rest of the function, including realloc
    *ap = a;
    *bp = b;
 }

swapStr(&a, &b, dimA, dimB);
Run Code Online (Sandbox Code Playgroud)

这确保如果您的ab指针被重新分配,则调用者的指针也会更新。


更喜欢使用正确类型的指针 ( char*) 而不是void*当它们指向char.