Java 8 Collections.sort - 简单的拼写错误

Tom*_*ell 0 java sorting java-7 java-8

基本上我有两个比较器(Comparator1和Comparator2),实现略有不同.两者都应按行的名称长度的降序对列表进行排序.

Comparator2似乎不适用于java7/java8.Comparator1始终有效.两者都适用于java 1.6实现,或者如果我设置-Djava.util.Arrays.useLegacyMergeSort = true.如果Comparator2中存在问题,则java应该抛出IllegalArgumentException,但不会抛出异常.

这在java文档中声明为"java.util.Arrays.sort使用的排序算法和java.util.Collections.sort(间接)使用的排序算法已被替换.如果新的排序实现检测到Comparable,则会抛出IllegalArgumentException违反可比较合约"

这是JRE中的错误还是Comparator2有问题?

public class Main {

public static void main(String[] args) {
    Row row1 = new Row("AAAA");
    Row row2 = new Row("BBB");
    Row row3 = new Row("CC");
    Row row4 = new Row("D");

    List<Row> list1 = new ArrayList<Row>();
    list1.add(row2);
    list1.add(row3);
    list1.add(row1);
    list1.add(row4);

    System.out.println("Before sorting:");
    System.out.println("");

    print(list1);

    Collections.sort(list1, new Comparator2());

    System.out.println("After sorting with comparator2:");
    System.out.println("");

    print(list1);

    Collections.sort(list1, new Comparator1());

    System.out.println("After sorting with comparator1:");
    System.out.println("");

    print(list1);

}

private static void print(List<Row> list) {
    for (Row row : list) {
        System.out.println(row.name);
    }
}

}

public class Row {

String name;

public Row(String name) {
    this.name = name;
}

public int getLength() {
    return name.length();
}

}

public class Comparator1 implements Comparator<Row> {
@Override
public int compare(Row o1, Row o2) {
    Integer length1 = o1.getLength();
    Integer length2 = o2.getLength();
    return -1 * length1.compareTo(length2);
}
}

public class Comparator2 implements Comparator<Row> {

@Override
public int compare(Row o1, Row o2) {
    int length1 = o1.getLength();
    int length2 = o2.getLength();

    if (length1 < length2) {
        return 1;
    } else if (length2 > length1) {
        return -1;
    } else {
        return 0;
    }

}

}
Run Code Online (Sandbox Code Playgroud)

gag*_*nbm 6

Comparator2中的前两个条件基本相同:

if (length1 < length2) {
    return 1;
} else if (length2 > length1) {
    return -1;
}
Run Code Online (Sandbox Code Playgroud)

更改else iflength1 > length2,它应该工作.

  • `Integer.compare(length1,length2)`更易读,更不容易出错. (2认同)