Rails编辑/更新操作不适用于嵌套项目

Oss*_*sie 1 controller ruby-on-rails nested-attributes ruby-on-rails-4

我已经为我的@miniature模型工作了新的/创建动作和表单,它是嵌套模型@scales.我无法正确进行更新/编辑操作.应该很简单,但我很困难.

@miniaturehas_many @scales通过@sizes.

在我的@miniature模型中,我有

    has_many :sizes, dependent: :destroy
    has_many :scales, :through => :sizes
    accepts_nested_attributes_for :sizes, allow_destroy: true
Run Code Online (Sandbox Code Playgroud)

在控制器中我有

    def new
        @miniature = Miniature.new 
        @all_scales = Scale.all
        @size = @miniature.sizes.build
    end

    def create
        @miniature = Miniature.new(miniature_params)
        params[:scales][:id].each do |scale|
          if !scale.empty?
            @miniature.sizes.build(:scale_id => scale)
          end
        end
        if @miniature.save
          redirect_to miniature
        else
          render 'new'
        end
    end

private
    def miniature_params
      params.require(:miniature).permit(:name, :release_date, :material, :pcode, :notes,  sizes_attributes: [:id, :scale_id, :miniset_id])
    end
Run Code Online (Sandbox Code Playgroud)

这有效但编辑和更新操作却没有.我的编辑设置与我的编辑相同.

def edit
    @miniature = Miniature.find(params[:id])
    @all_scales = Scale.all
    @size = @miniature.sizes.build
end
Run Code Online (Sandbox Code Playgroud)

我原以为更新miniature params会更新@sizes模型,但事实并非如此

def update
    @miniature = Miniature.find(params[:id])
    if @miniature.update_attributes(miniature_params)
      flash[:success] = "Miniature updated"
      redirect_to @miniature
    else
      render 'edit'
    end
end
Run Code Online (Sandbox Code Playgroud)

它目前更新@miniature但不更新@sizes信息.我的问题出现在编辑或更新中,还是两者都有?

表格的相关部分:

<%= f.fields_for(@size) do |sf| %>
      <%= sf.label simple_pluralize(@miniature.scales.count, 'Scale') %>

        <%= collection_select( :scales, :id, @all_scales, :id, :name, 
                   {:selected => @miniature.scales.map(&:id)}, 
                   {class: 'multiselect', multiple: true}) %>
<% end %>
Run Code Online (Sandbox Code Playgroud)

任何帮助或指向进一步阅读非常赞赏.即使它只是说"你忽略了这个显而易见的事情,去做更多的阅读/工作".

似乎我需要有一个update更类似于我的create行动if声明的行动?

更新 JKen13579

这是提交编辑时来自我的服务器日志的PATCH请求:

Started PATCH "/miniatures/21" for 127.0.0.1 at 2014-04-02 16:00:10 +0100
Processing by MiniaturesController#update as HTML
  Parameters: {"utf8"=>"?", "authenticity_token"=>"jQ79L1Exx83C47jnCF3nsWQ2tV07tRwKfI8wNeLzojo=", "miniature"=>{"name"=>"Test Miniature", "material"=>"Metal", "pcode"=>"123123123123123", "release_date(1i)"=>"2013", "release_date(2i)"=>"2", "release_date(3i)"=>"2", "notes"=>""}, "scales"=>{"id"=>["", "2"]}, "commit"=>"Save changes", "id"=>"21"}
  User Load (0.7ms)  SELECT "users".* FROM "users" WHERE "users"."id" = 4 ORDER BY "users"."id" ASC LIMIT 1
  Miniature Load (0.2ms)  SELECT "miniatures".* FROM "miniatures" WHERE "miniatures"."id" = ? LIMIT 1  [["id", "21"]]
   (0.1ms)  begin transaction
   (0.2ms)  commit transaction
Redirected to http://localhost:3000/miniatures/21
Completed 302 Found in 12ms (ActiveRecord: 1.3ms)
Run Code Online (Sandbox Code Playgroud)

观察者更新

我正在使用fields_for,因为这是我设法获得新的/创建操作.如果有更好的方法,至少据我所知,我并不依赖它.

我的路线有

resources :miniatures do
    collection do
    get :scales
    get :collections
    get :lines
    get :contents
    post :import
    end
    member do
      get :minisets, :setminis
    end
  end
Run Code Online (Sandbox Code Playgroud)

并进一步下来

resources :sizes
resources :scales
Run Code Online (Sandbox Code Playgroud)

我认为我的路由文件通常有点杂乱,并且应该进行重构.

Kir*_*rat 5

根据服务器日志条目(见下文),我看到在params哈希中,scales(以粗体突出显示)作为单独的哈希 传递,而不是在miniature:

参数:{"utf8"=>"✓","authenticity_token"=>"jQ79L1Exx83C47jnCF3nsWQ2tV07tRwKfI8wNeLzojo =","微型"=> {"名称"=>"测试微型","材料"=>"金属","pcode" >>"123123123123123","release_date(1i)"=>"2013"​​,"release_date(2i)"=>"2","release_date(3i)"=>"2","notes"=>""} , "scales"=> {"id"=> ["","2"]},"commit"=>"保存更改","id"=>"21"}

update操作更改为:

def update
    @miniature = Miniature.find(params[:id])
    if params[:scales][:id]
      ## Convert ["", "1","2","4","8"] to [1,2,4,8]
      params[:scales][:id] = params[:scales][:id].reject(&:empty?).map(&:to_i) 
      ## Get the scale_id from sizes already present in database [1,2,5,6] 
      old_scales = @miniature.sizes.pluck(:scale_id)
      ## Find the new scales to be added [1,2,4,8] - [1,2,5,6] = [4,8]
      new_scales = params[:scales][:id] - old_scales 
      ## Find the old_scales to be deleted [1,2,5,6] - [1,2,4,8] = [5,6]
      old_scales = old_scales - params[:scales][:id] 
      ## Build new_scales [4,8]
      new_scales.each do |scale|
        @miniature.sizes.build(:scale_id => scale)
      end
      ## Delete old_scales [5,6]
      Size.delete_all(:scale_id => old_scales)
    end
    if @miniature.update_attributes(miniature_params)
      flash[:success] = "Miniature updated"
      redirect_to @miniature
    else
      render 'edit'
    end
end
Run Code Online (Sandbox Code Playgroud)

更新create操作,因此scale_id传递为Integer而不是String:

def create
    @miniature = Miniature.new(miniature_params)
    if params[:scales][:id]
      ## Convert ["", "1","2","4","8"] to [1,2,4,8]
      params[:scales][:id] = params[:scales][:id].reject(&:empty?).map(&:to_i)
      params[:scales][:id].each do |scale|
        @miniature.sizes.build(:scale_id => scale)
      end
    end
    if @miniature.save
      redirect_to miniature
    else
      render 'new'
    end
end
Run Code Online (Sandbox Code Playgroud)

  • 那很棒!!这是我的第一次赏金胜利.我一定记得这个.另外,为你的`create`动作添加了(Bonus)更新.:) (2认同)