如何在我的C++程序中修复此堆栈溢出错误?

Emm*_*N K 3 c++ stack-overflow constructor memory-management

所以,我是C++的初学者......我认为我已经牢牢掌握了动态内存分配,但我想我没有.我在网上搜索了很多解决方案,但我仍然无法解决我的问题.我一直收到错误0xC00000FD:运行调试时堆栈溢出.我很确定这个问题与我在默认构造函数中分配内存的方式有关,但也许是其他的东西.我想我需要更深入的见解.任何帮助或暗示确定问题将不胜感激.

这是一个从用户输入计算矩形的面积和周长的简单程序.

这是头文件:

#pragma once
class my_Rectangle
{
private:
    float m_area;
    float m_perimeter;
    float m_length;
    float m_width;
    void update_rec();
    my_Rectangle*tempSTORE;
public:
    float calc_area(float length,float width);
    float calc_perim(float length,float width);
    void change_RECTsize(float length,float width,my_Rectangle tempSTORE);


    my_Rectangle(); //constructor
    my_Rectangle(float length,float width);
    ~my_Rectangle(); //destructor
};
Run Code Online (Sandbox Code Playgroud)

这是类成员定义文件:

#include "StdAfx.h"
#include "my_Rectangle.h"
#include <iostream>

//using namespace std;

//This function calculates the area
float my_Rectangle::calc_area(float length,float width)
{
    float area = width * length;

    std::cout<<"\nThe area of the rectangle is: "<<area<<" square metres."<<std::endl;  // ::scope operater
    return area;
}

//This function calculates the perimeter
float my_Rectangle::calc_perim(float length,float width)
{
float perimeter=(2*length)+(2*width);

std::cout<<"\nThe perimeter of the rectangle is "<<perimeter<<" metres."<<std::endl;
return perimeter;
}
//this function changes the size of the rectangle
void my_Rectangle::change_RECTsize(float length,float width,my_Rectangle tempSTORE)
{
    tempSTORE.m_length=length;
    tempSTORE.m_width=width;
    my_Rectangle::calc_area(length,width);
    my_Rectangle::calc_perim(length,width);
}



my_Rectangle::my_Rectangle() //default constructor
{
    tempSTORE=new my_Rectangle;

    tempSTORE->m_length=0.00;
    tempSTORE->m_width=0.00;
    tempSTORE->m_area=0.00;
    tempSTORE->m_perimeter=0.00;

}
my_Rectangle::my_Rectangle(float length,float width) //initialized constructor
{
    tempSTORE=new my_Rectangle;

    tempSTORE->m_length=length;
    tempSTORE->m_width=width;
    calc_area(length,width);
    calc_perim(length,width);
}


my_Rectangle::~my_Rectangle() //destructor
{
     delete tempSTORE;
std::cout<<"\nThe memory has been freed!!"<<std::endl; 
Run Code Online (Sandbox Code Playgroud)

这是客户端文件:

#include "stdafx.h"
#include "my_Rectangle.h"
#include <iostream>
using namespace std;


int _tmain(int argc, _TCHAR* argv[])
{
    float xlength,xwidth;

    cout<<"Welcome to the rectangle Area Calculator!"<<endl;
    cout<<"Please enter the length and width of your rectangle:"<<endl;
    cout<<"Length: "; cin>>xlength;
    cout<<"Width: "; cin>>xwidth;


    cout<<"Rectangle Information:"<<endl;
    cout<<"Length: "<<xlength<<"m\tWidth: "<<xwidth<<" m"<<endl;
    my_Rectangle userRECT(xlength,xwidth);

    reTRY:
    int user_choice;
    cout<<"More options:"<<endl;
    cout<<"1. Change rectangle size"<<endl;
    cout<<"2. Exit"<<endl;
    cout<<"Enter a number: ";
    cin>>user_choice;
    switch (user_choice)
    {
    case 1:
        cout<<"Please enter the new length and width of rectangle:"<<endl;
        cout<<"Length: "; cin>>xlength;
        cout<<"Width: "; cin>>xwidth;
        cout<<"\nRectangle Information:"<<endl;
        cout<<"Length: "<<xlength<<"m\tWidth: "<<xwidth<<" m"<<endl;
        userRECT.change_RECTsize(xlength,xwidth,userRECT);
        break; 
    case 2:
        exit(1);
        break; 
    default: cout<<"\nThat is not a valid option. Please try again!" ;
     goto reTRY;
     break; 
    }


     cin.get();cin.get();
    return 0;
}
Run Code Online (Sandbox Code Playgroud)

Rei*_*ica 9

堆栈溢出与动态分配几乎没有关系 - 堆栈用于函数调用和局部变量(静态和自动分配).但是在默认构造函数中确实有无限递归:

my_Rectangle::my_Rectangle() //default constructor
{
    tempSTORE=new my_Rectangle;
Run Code Online (Sandbox Code Playgroud)

这将分配tempSTORE并调用默认构造函数,它将分配一个tempSTORE,...


你似乎对记忆和施工操作的顺序感到困惑.构造函数和析构函数在已由其他人分配的内存上运行.顺序如下:

  1. 内存以某种方式分配(在堆栈上为局部变量,在堆上new)
  2. 构造函数在内存中自动执行
  3. 对象生活
  4. 启动对象死亡(局部变量超出范围,有人调用delete)
  5. 析构函数在内存中自动执行
  6. 内存被释放

这意味着你的构造函数不应该关心为它正在构造的对象获取内存,它已经被某人提供了.析构函数也不应该关心释放对象本身占用的内存,一旦析构函数结束,这将由其他人完成.

要了解更多相关信息,我建议您阅读一本好书.