Rspec不会改变创建的数量

Question

我正在尝试用我的rspec测试来解决一个问题来创建一个对象,但计数似乎没有改变我尝试的任何东西.我相信我错过了一些非常基本的东西.

这是我的rspec:

 before do
    login_account_admin(user)
    @group = Factory(:group, :code => "GR_111", :description => "description for GR_111")
    Group.stub!(:find).and_return(@group)
  end

  describe "#create" do

    it "should create a new group object" do
      group_params = {:code => "NEW_GROUP", :description => "description for NEW_GROUP"}
      expect {
        post :create, :service_id => service, :cdb_group => group_params, :button => "save", :format => "js"
      }.to change(Group, :count).by(1)
    end

    it "should not create a new group object with invalid code format" do
      group_params = {:code => "invalid", :description => "description for invalid code name group"}
      expect {
        post :create, :service_id => service, :cdb_group => group_params, :button => "save", :format => "js"
      }.to_not change(Group, :count)
    end

  end

"code"参数只能包含大写字母A到Z,0-9和_

这是#create的控制器方法定义

def create
@group = Group.new(params[:cdb_group])
respond_to do |format|
  if params[:button] == "cancel"
    format.js   { render "hide_new"}
  elsif @group.save
    format.js   {
      render 'show_new_group'
    }
    format.html { redirect_to(some_path(@service), :notice => 'Group was successfully created.') }
    format.xml  { head :ok }
  end
end
end

这是集团模型:

class Group < ActiveRecord::Base

    validates_uniqueness_of :code
    validates_presence_of :code, :description
    validates_format_of :code, :without => /[^A-Z0-9_]/ , :message => 'can only contain uppercase letters A to Z, 0-9 and _'
end

每当我尝试运行rspec测试时,我会收到以下错误: -

 1) GroupsController User As Account Admin goes to #create should create a new group object
 Failure/Error: expect {
   count should have been changed by 1, but was changed by 0
 # ./spec/controllers/groups_controller_spec.rb:51

 2) GroupsController User As Account Admin goes to #create should not create a new group object with invalid code format
 Failure/Error: expect {
   count should not have changed, but did change from 2 to 1
 # ./spec/controllers/groups_controller_spec.rb:58

在这方面的任何帮助将受到高度赞赏？

Answer 1

每当我们的测试给我们带来意想不到的麻烦时,重要的是退后一步并重新评估我们的方法.通常,这表示某些设计问题,无论是我们正在测试的代码还是测试本身.

虽然听起来像使用截断策略已经解决了这个特殊问题(请参阅下面的更多内容),我建议还有更多可以从这种情况中学习.

考虑上面的规范中的两个示例.它们之间的唯一区别归结为code参数是否有效.我认为这些例子实际上是测试Group 模型,而不是控制器.

现在,如果我们对模型测试覆盖率有信心,那么我们可以对控制器规范采取不同的方法.从控制器的角度来看,该模型是一个协作者,总的来说,我们总是希望避免间接测试协作者.在这种情况下,我们可以使用模拟来模拟模型的行为,Group并仅隔离地测试控制器行为.

这样的事情(请注意下面的代码是不完整和未经测试的):

# spec/controllers/groups_controller_spec.rb
describe "#create" do

  before do
    # use a Test Double instead of a real model
    @new_group = double(Group)
    @params = { :cdb_group => 'stub_cdb_group_param', :service_id => service }
    # using should_receive ensures the controller calls new correctly
    Group.should_receive(:new).with(@params[:cdb_group]).and_return(@new_group)
  end

  context "when cancelled responding to js" do
    it "renders hide_new" do
      post :create, @params.merge({:button => "cancel", :format => "js"})
      expect(response).to render_template('hide_new')
    end
  end

  context "with valid params" do
    before do
      @new_group.should_receive(:save).and_return(true)
    end

    context "responding to json"  # ...

    context "responding to html"  # ...

    context "responding to xml"   #...
  end

  context "with invalid params" do
    before do
      @new_group.should_receive(:save).and_return(false)
    end

    # ...
  end

end

虽然上面没有具体解决您所记录的记录计数问题,但我怀疑一旦您正确隔离测试目标,问题可能会消失.

如果你选择坚持与数据库截断,如所描述考虑使用它选择这里.

我希望至少有一些帮助:).