Reb*_*_87 2 c++ sorting pointers linked-list bubble-sort
我试图使用冒泡排序来排序链表.我使用curr和trail来遍历列表.curr应该始终领先于一步.到目前为止这是我的代码:
void linked_list::sort ()
{
int i,j=0;
int counter=0;
node *curr=head;
node *trail=head;
node *temp=NULL;
while (curr !=NULL)
{
curr=curr->next; //couting the number of items I have in my list.
counter++; //this works fine.
}
curr=head->next; // reseting the curr value for the 2nd position.
for (i=0; i<counter; i++)
{
while (curr != NULL)
{
if (trail->data > curr->data)
{
temp=curr->next; //bubble sort for the pointers.
curr->next=trail;
trail->next=temp;
temp=curr; //reseting trail and curr. curr gets back to be infront.
curr=trail;
trail=temp;
if (j==0) //i'm using j to determine the start of the loop so i won't loose the head pointer.
{
head=trail;
}
}
j++;
trail=curr;
curr=curr->next; //traversing thru the list. nested loop.
}
trail=head;
curr=trail->next;
curr->next=trail->next->next; //traversing thru the list. outer loop.
j=0;
}
}
Run Code Online (Sandbox Code Playgroud)
我在这里错过了什么?
Who*_*aig 10
你错过了几件事; 最重要的链接列表不是数组,因此你不能轻易地互换地做某些算法.请考虑以下因素:
next转到),就会达到"完成"状态.现在来看看以下截然不同的方法.其中有一些东西对于理解整体算法至关重要,但我会在代码之后保存它:
void ll_bubblesort(struct node **pp)
{
// p always points to the head of the list
struct node *p = *pp;
*pp = nullptr;
while (p)
{
struct node **lhs = &p;
struct node **rhs = &p->next;
bool swapped = false;
// keep going until qq holds the address of a null pointer
while (*rhs)
{
// if the left side is greater than the right side
if ((*rhs)->data < (*lhs)->data)
{
// swap linked node ptrs, then swap *back* their next ptrs
std::swap(*lhs, *rhs);
std::swap((*lhs)->next, (*rhs)->next);
lhs = &(*lhs)->next;
swapped = true;
}
else
{ // no swap. advance both pointer-pointers
lhs = rhs;
rhs = &(*rhs)->next;
}
}
// link last node to the sorted segment
*rhs = *pp;
// if we swapped, detach the final node, terminate the list, and continue.
if (swapped)
{
// take the last node off the list and push it into the result.
*pp = *lhs;
*lhs = nullptr;
}
// otherwise we're done. since no swaps happened the list is sorted.
// set the output parameter and terminate the loop.
else
{
*pp = p;
break;
}
}
}
Run Code Online (Sandbox Code Playgroud)
这与您预期的完全不同.这个简单练习的目的是确定我们正在评估数据,但实际上我们正在对指针进行排序.请注意,除了p始终是列表的头部之外,我们不使用任何指向节点的附加指针.相反,我们使用指针指针来操纵埋在列表中的指针.
为了演示这个算法是如何工作的,我编写了一个小的测试应用程序,它会生成一个随机的整数列表,然后在上面的列表中将上面的内容放松.我还编写了一个简单的print-utility来从任何节点到最后打印列表.
void ll_print(struct node *lst)
{
while (lst)
{
std::cout << lst->data << ' ';
lst = lst->next;
}
std::cout << std::endl;
}
int main()
{
std::random_device rd;
std::default_random_engine rng(rd());
std::uniform_int_distribution<int> dist(1,99);
// fill basic linked list
struct node *head = nullptr, **pp = &head;
for (int i=0;i<20; ++i)
{
*pp = new node(dist(rng));
pp = &(*pp)->next;
}
*pp = NULL;
// print prior to sort.
ll_print(head);
ll_bubblesort(&head);
ll_print(head);
return 0;
}
Run Code Online (Sandbox Code Playgroud)
我还修改了原始算法,以便在每次传递之后包含打印:
*pp = *lhs;
*lhs = nullptr;
ll_print(p);
Run Code Online (Sandbox Code Playgroud)
样本输出
6 39 13 80 26 5 9 86 8 82 97 43 24 5 41 70 60 72 26 95
6 13 39 26 5 9 80 8 82 86 43 24 5 41 70 60 72 26 95
6 13 26 5 9 39 8 80 82 43 24 5 41 70 60 72 26 86
6 13 5 9 26 8 39 80 43 24 5 41 70 60 72 26 82
6 5 9 13 8 26 39 43 24 5 41 70 60 72 26 80
5 6 9 8 13 26 39 24 5 41 43 60 70 26 72
5 6 8 9 13 26 24 5 39 41 43 60 26 70
5 6 8 9 13 24 5 26 39 41 43 26 60
5 6 8 9 13 5 24 26 39 41 26 43
5 6 8 9 5 13 24 26 39 26 41
5 6 8 5 9 13 24 26 26 39
5 6 5 8 9 13 24 26 26
5 5 6 8 9 13 24 26
5 5 6 8 9 13 24 26 26 39 41 43 60 70 72 80 82 86 95 97
Run Code Online (Sandbox Code Playgroud)
另一个样本
62 28 7 24 89 20 94 26 27 21 28 76 60 51 99 20 94 48 81 36
28 7 24 62 20 89 26 27 21 28 76 60 51 94 20 94 48 81 36
7 24 28 20 62 26 27 21 28 76 60 51 89 20 94 48 81 36
7 24 20 28 26 27 21 28 62 60 51 76 20 89 48 81 36
7 20 24 26 27 21 28 28 60 51 62 20 76 48 81 36
7 20 24 26 21 27 28 28 51 60 20 62 48 76 36
7 20 24 21 26 27 28 28 51 20 60 48 62 36
7 20 21 24 26 27 28 28 20 51 48 60 36
7 20 21 24 26 27 28 20 28 48 51 36
7 20 21 24 26 27 20 28 28 48 36
7 20 21 24 26 20 27 28 28 36
7 20 21 24 20 26 27 28 28
7 20 21 20 24 26 27 28
7 20 20 21 24 26 27
7 20 20 21 24 26 27 28 28 36 48 51 60 62 76 81 89 94 94 99
Run Code Online (Sandbox Code Playgroud)
请注意,只要我们在不断减少的源列表中留下已经排序的段,我们就完成了.
摘要
我强烈建议使用调试器来完成上述算法,以更好地了解它的工作原理.事实上,无论如何,我建议使用大多数算法,但执行指针到指针操作的算法可能会有点令人生畏,直到您了解它的强大程度.这不是执行此任务的唯一方法,但如果您考虑如何管理链接列表,以及您实际所做的是如何更改存储在可预测位置的指针中的值,这是一种直观的方法.
基本上,这是一个修订的排序.你大多有正确的想法.主要是你搞砸了节点指针的交换.这是一个稍微简单的修改算法.外部循环是for列表中元素的数量.然后内部循环是逐步将值推送到列表的末尾.我们跟踪两个指针trail和curr.我们比较curr和curr->next.
void linked_list::sort ()
{
int count = 0, i;
node *start = head;
node *curr = NULL;
node *trail = NULL;
node *temp = NULL;
while(start != NULL) { //grab count
count++;
start = start->next;
}
for(i = 0; i<count; ++i) { //for every element in the list
curr = trail = head; //set curr and trail at the start node
while (curr->next != NULL) { //for the rest of the elements in the list
if (curr->data > curr->next->data) { //compare curr and curr->next
temp = curr->next; //swap pointers for curr and curr->next
curr->next = curr->next->next;
temp->next = curr;
//now we need to setup pointers for trail and possibly head
if(curr == head) //this is the case of the first element swapping to preserve the head pointer
head = trail = temp;
else //setup trail correctly
trail->next = temp;
curr = temp; //update curr to be temp since the positions changed
}
//advance pointers
trail = curr;
curr = curr->next;
}
}
}
Run Code Online (Sandbox Code Playgroud)
| 归档时间: |
|
| 查看次数: |
44377 次 |
| 最近记录: |