何时创建新任务

Question

我正在学习C#.NET 4.5中的任务并行,我对一个例子感到有些困惑.这是我不明白的代码:

public static Task<string> DownloadStringAsync(string address)
{
  // First try to retrieve the content from cache. 
  string content;
  if (cachedDownloads.TryGetValue(address, out content))
  {
     return Task.FromResult<string>(content);
  }

  // If the result was not in the cache, download the  
  // string and add it to the cache. 
  return Task.Run(async () => // why create a new task here?
  {
     content = await new WebClient().DownloadStringTaskAsync(address);
     cachedDownloads.TryAdd(address, content);
     return content;
  });
}

具体来说,我不明白他们为什么要包装DownloadStringTaskAsync()其他任务.还没有DownloadStringTaskAsync()在自己的线程上运行？

这是我编写它的方式:

public static async Task<string> DownloadStringAsync(string address)
{
    // First try to retrieve the content from cache.
    string content;
    if (cachedDownloads.TryGetValue(address, out content))
    {
        return content;
    }

    // If the result was not in the cache, download the  
    // string and add it to the cache.
    content = await new WebClient().DownloadStringTaskAsync(address);
    cachedDownloads.TryAdd(address, content);
    return content;
}

两者有什么区别？哪一个更好？

Answer 1

好吧,该示例专门展示了如何使用Task.FromResult,您的第二个代码不使用.也就是说,我不同意Task.Run示例中的用法.

我自己就这样写了:

public static Task<string> DownloadStringAsync(string address)
{
  // First try to retrieve the content from cache.
  string content;
  if (cachedDownloads.TryGetValue(address, out content))
  {
    return Task.FromResult(content);
  }

  // If the result was not in the cache, download the  
  // string and add it to the cache.
  return DownloadAndCacheStringAsync(address);
}

private static async Task<string> DownloadAndCacheStringAsync(string address)
{
  var content = await new WebClient().DownloadStringTaskAsync(address);
  cachedDownloads.TryAdd(address, content);
  return content;
}

另请注意,该示例使用日期WebClient,应HttpClient在新代码中替换.

总的来说,它看起来只是一个不好的例子IMO.